X Tutup
The Wayback Machine - https://web.archive.org/web/20201004215120/https://github.com/orbitdb/orbit-db/issues/792
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manifest & access controller becomes unpinned by ipfs repo GC #792

Open
phillmac opened this issue May 12, 2020 · 4 comments
Open

Manifest & access controller becomes unpinned by ipfs repo GC #792

phillmac opened this issue May 12, 2020 · 4 comments

Comments

@phillmac
Copy link
Member

@phillmac phillmac commented May 12, 2020

We need to automatically pin both the manifest and the access controller during db open to prevent go-ipfs from deleting them while performing repo garbage collection.

@tabcat
Copy link
Member

@tabcat tabcat commented May 13, 2020

I'm guessing you would also unpin the data when the store is dropped

@mistakia
Copy link
Contributor

@mistakia mistakia commented May 22, 2020

I don't see this documented anywhere, but I think if you pass { pin: true } to orbitdb.create that may pin the manifest. I'm not sure if that will recursively pin the access controller. My guess is no.

From what I can tell there is no way to pin the ac or manifest for an already created db.

@aphelionz
Copy link
Member

@aphelionz aphelionz commented May 26, 2020

Started work on this at the ACL level here: orbitdb/orbit-db-access-controllers#45

@aphelionz
Copy link
Member

@aphelionz aphelionz commented May 26, 2020

Unfortunately pin: true will not work :(

@aphelionz aphelionz added this to Backlog / Triage in Release 0.25.0 May 30, 2020
@aphelionz aphelionz moved this from Backlog / Triage to To Do in Release 0.25.0 May 30, 2020
@aphelionz aphelionz moved this from To Do to In Progress in Release 0.25.0 May 30, 2020
@aphelionz aphelionz removed this from In Progress in Release 0.25.0 Aug 24, 2020
@aphelionz aphelionz added this to Triage in Release 0.25.2 Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.
X Tutup