X Tutup
The Wayback Machine - https://web.archive.org/web/20220519204101/https://github.com/plotly/plotly.js/pull/4969
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix median transform aggregation #4969

Merged
merged 1 commit into from Jun 30, 2020
Merged

Fix median transform aggregation #4969

merged 1 commit into from Jun 30, 2020

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Jun 30, 2020

Fixes #4966 by using numeric sort function instaed of default.

@plotly/plotly_js

Copy link
Contributor

@alexcjohnson alexcjohnson left a comment

💃 JavaScript's default sort function is one of the most frustrating choices they made - especially since in many cases it does the right thing anyway so it can make you think you're safe.

@archmoj archmoj merged commit b08d780 into master Jun 30, 2020
9 checks passed
@archmoj archmoj deleted the fix4966-median-sort branch Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
X Tutup