X Tutup
The Wayback Machine - https://web.archive.org/web/20201106182922/https://github.com/oneapi-src/oneDNN/pull/852
Skip to content

/ oneDNN

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC for VTune-ITT-tagging #852

Open
wants to merge 5 commits into
base: rfcs
from
Open

RFC for VTune-ITT-tagging #852

wants to merge 5 commits into from

Conversation

@louie-tsai
Copy link
Contributor

@louie-tsai louie-tsai commented Oct 15, 2020 •
edited by emfomenk

Description

RFC for VTune ITT tagging feature

Link to the rendered document.

RFC PR

  • Does RFC document follow the template?
  • Have you added a link to the rendered document?

Edit: added a link to the rendered document.
louie-tsai added 2 commits Oct 14, 2020
@louie-tsai
RFC for VTune-ITT-tagging
21c0764
@louie-tsai
remove itt_task_level_medium
a806cb5
@sbogusev
sbogusev reviewed Oct 24, 2020
View changes
Copy link
Contributor

@sbogusev sbogusev left a comment

Thanks very much for the proposal, I think this feature would be very valuable for oneDNN. Please find below some comments.
rfcs/20201014-VTune-ITT-tagging/README.md Outdated Show resolved Hide resolved
rfcs/20201014-VTune-ITT-tagging/README.md Show resolved Hide resolved
rfcs/20201014-VTune-ITT-tagging/README.md Outdated Show resolved Hide resolved
rfcs/20201014-VTune-ITT-tagging/README.md Outdated Show resolved Hide resolved
rfcs/20201014-VTune-ITT-tagging/README.md Outdated Show resolved Hide resolved
rfcs/20201014-VTune-ITT-tagging/README.md Show resolved Hide resolved
rfcs/20201014-VTune-ITT-tagging/README.md Outdated Show resolved Hide resolved
rfcs/20201014-VTune-ITT-tagging/README.md Outdated Show resolved Hide resolved
rfcs/20201014-VTune-ITT-tagging/README.md Outdated Show resolved Hide resolved
rfcs/20201014-VTune-ITT-tagging/README.md Outdated Show resolved Hide resolved
louie-tsai added 3 commits Oct 26, 2020
@louie-tsai
changes according to sbogusev's feedback
691cab4
@louie-tsai
remove VTune name from implementation according to VTune team's feedback
3f3c715
@louie-tsai
changes according to sbogusev's feedback
9143523
@louie-tsai louie-tsai force-pushed the louie-tsai:rfcs branch from 020105d to 9143523 Oct 30, 2020
@sbogusev
sbogusev approved these changes Nov 4, 2020
View changes
@sbogusev sbogusev added the RFC label Nov 4, 2020
@sbogusev
sbogusev reviewed Nov 4, 2020
View changes
rfcs/20201014-VTune-ITT-tagging/README.md

## Open Questions

1. Should we set DNNL_ITT_TASK_LEVEL as __itt_task_level_high by default?

This comment has been minimized.

Sign in to view
@sbogusev

sbogusev Nov 4, 2020
Contributor

I think using __itt_task_level_high as default would be useful, however feedback from VTune team would be very welcome here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbogusev sbogusev

Assignees
No one assigned
Labels
RFC
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@louie-tsai @sbogusev
You can’t perform that action at this time.
X Tutup