X Tutup
The Wayback Machine - https://web.archive.org/web/20201027175041/https://github.com/cli/cli/issues/1682
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For `pr checks` cmd, add -w flag to view checks tab on github.com #1682

Open
tierninho opened this issue Sep 11, 2020 · 5 comments · May be fixed by #2146
Open

For `pr checks` cmd, add -w flag to view checks tab on github.com #1682

tierninho opened this issue Sep 11, 2020 · 5 comments · May be fixed by #2146

Comments

@tierninho
Copy link
Contributor

@tierninho tierninho commented Sep 11, 2020

Describe the feature or problem you’d like to solve

When running gh pr checks the user is shown a bunch of urls for each check. It would be great to add a -w to see the checks tab ([repo/owner]/pull/[pr-number]/checks) in github.com. The user could then scroll through the various checks shown in the output of the gh pr checks.

Proposed solution

How will it benefit CLI and its users?
This will benefit users by giving them a quick option to pull up more details on each check.

@jacobat
Copy link

@jacobat jacobat commented Oct 19, 2020

Checks are not necessarily listed in the checks tab. The way we do PR's the checks are listed at the bottom of the conversation tab and nothing is on the checks tab. So for people like us this behaviour would be confusing.

@mislav
Copy link
Member

@mislav mislav commented Oct 19, 2020

@jacobat Thank you for the context! It sounds like your repo is using Statuses instead of Checks, which would explain why they are not listed in the Checks tab.

I think that pr checks --web flag might still be useful for people who uses Checks (and not Statuses) in their repositories.

@jacobat
Copy link

@jacobat jacobat commented Oct 20, 2020

Just to be clear: Statuses show up when doing gh pr checks - which is why it could be confusing for people that --web would go to the checks page which would then be empty.

The reason I ended up here was because I would like a --web that opened the statuses :)

@mislav
Copy link
Member

@mislav mislav commented Oct 21, 2020

@jacobat I see! I don't think there is a web view that displays Statuses for a PR, so would you expect that --web would take you to the Merge Box of a PR where Checks+Statuses are displayed live?

@jacobat
Copy link

@jacobat jacobat commented Oct 21, 2020

That would be an option. In my case the status points to our CI, so even better would be to go straight to the CI page (the url is part of the output from gh pr checks). This is probably not a good solution for everyone though since you can have multiple statuses.

Here's an example of the output I see for reference:

All checks were successful
0 failing, 1 successful, and 0 pending checks

✓  continuous-integration/push    https://my-ci.com/build/123
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

6 participants
@mislav @jacobat @vilmibm @tierninho and others
You can’t perform that action at this time.
X Tutup