X Tutup
The Wayback Machine - https://web.archive.org/web/20201204181505/https://github.com/sequelize/sequelize/pull/12800
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added fix for multi composite key to V5 branch #12800

Open
wants to merge 2 commits into
base: v5
from
Open

Conversation

@cskiwi
Copy link

@cskiwi cskiwi commented Oct 31, 2020

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

Added the fix from #11984 to the v5 branch.
This is needed for people using 'sequelize-typescript' because that doesn't work on v6 yet

cskiwi added 2 commits Oct 31, 2020
@hsource
Copy link
Contributor

@hsource hsource commented Nov 18, 2020

It looks like sequelize-typescript will support v6 (see RobinBuschmann/sequelize-typescript#807), including v6.2+ hopefully soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.
X Tutup