X Tutup
The Wayback Machine - https://web.archive.org/web/20201204181518/https://github.com/sequelize/sequelize/pull/12771
Skip to content

/ sequelize

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fixing typo dialect for mssql connection #12771

Open
wants to merge 2 commits into
base: v6
from
Open

docs: fixing typo dialect for mssql connection #12771

wants to merge 2 commits into from

Conversation

@ilhamarrouf
Copy link

@ilhamarrouf ilhamarrouf commented Oct 19, 2020

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change
@ilhamarrouf
docs: fixing typo dialect for mssql connection
Loading status checks…
4e22d04
@codecov
Copy link

@codecov codecov bot commented Oct 19, 2020 •
edited

Codecov Report

Merging #12771 (4e22d04) into v6 (a329bb7) will increase coverage by 2.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##               v6   #12771      +/-   ##
==========================================
+ Coverage   94.38%   96.44%   +2.05%     
==========================================
  Files          95       95              
  Lines        9162     9162              
==========================================
+ Hits         8648     8836     +188     
+ Misses        514      326     -188
Impacted Files Coverage Δ
lib/dialects/abstract/query-generator.js 97.39% <0.00%> (+0.16%) ⬆️
lib/dialects/abstract/query.js 91.98% <0.00%> (+0.32%) ⬆️
lib/sequelize.js 95.87% <0.00%> (+3.17%) ⬆️
lib/dialects/mysql/query-generator.js 97.56% <0.00%> (+3.41%) ⬆️
lib/dialects/mysql/data-types.js 98.43% <0.00%> (+54.68%) ⬆️
lib/dialects/mysql/connection-manager.js 96.29% <0.00%> (+66.66%) ⬆️
lib/dialects/mysql/query.js 98.27% <0.00%> (+83.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a329bb7...6d957f3. Read the comment docs.
@ilhamarrouf
docs: added quotation mark at example getters atributes of models
Loading status checks…
6d957f3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
@ilhamarrouf
You can’t perform that action at this time.
X Tutup