Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Fixed bug #2450 -> Update chart throws Exception #4937
Conversation
Fixed a IndexOutOfRangeException that occurred irregularly if the chart gets permanently updated. The bug occurs in the legend renderer. I put the responsible code into a synchronized block and surrounded the critical code by a try-catch. Despite the synchronized, the exception gets sometimes thrown, which the try block catches and replaces the needed vertical space by a cached value.
Fixed a NullPointerException if calculatedLabelBreakPoints is null.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Fixed a IndexOutOfRangeException that occurred irregularly if the chart gets permanently updated.
The bug occurs in the legend renderer. I put the responsible code into a synchronized block and surrounded the critical code by a try-catch. Despite the synchronized, the exception gets sometimes thrown, which the try block catches and replaces the needed vertical space by a cached value.
PR Checklist:
PR Description
Fixes a IndexOutOfRangeException if data of a chart is updated permanently.
Introduced synchronized section and surrounded critical code by a try-catch block.
If you update the data permanently (live data), the whole app crashes after seconds, or minutes (irregularly). This can not be caught in the app, but only in the framework.