X Tutup
The Wayback Machine - https://web.archive.org/web/20201102184203/https://github.com/flutter/flutter/pull/69550
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flutter_tools] add canvaskit hot reload integration test #69550

Merged

Conversation

@jonahwilliams
Copy link
Member

@jonahwilliams jonahwilliams commented Nov 2, 2020

Description

Add a hot reload integration test for canvaskit. Currently skipped due to failures.

@@ -451,6 +451,7 @@ class FlutterRunTestDriver extends FlutterTestDriver {
bool singleWidgetReloads = false,
File pidFile,
String script,
List<String> args,

This comment has been minimized.

@ferhatb

ferhatb Nov 2, 2020
Contributor

intentional or test code? Please add comment for args otherwise

This comment has been minimized.

@jonahwilliams

jonahwilliams Nov 2, 2020
Author Member

Its all test code, but i changed the name to be more descriptive.

@jonahwilliams jonahwilliams requested a review from ferhatb Nov 2, 2020
@jonahwilliams
Copy link
Member Author

@jonahwilliams jonahwilliams commented Nov 2, 2020

Landing this with the retries to kick the tree. We're currently closed on web hot restart tests and I want to make sure they're passing at least some of the time.

@jonahwilliams jonahwilliams merged commit 8291f48 into flutter:master Nov 2, 2020
28 of 29 checks passed
28 of 29 checks passed
flutter-build Flutter build is currently broken. Please do not merge this PR unless it contains a fix to the broken build.
Details
Linux analyze
Details
Linux build_gallery
Details
Linux build_tests
Details
Linux customer_testing
Details
Linux firebase_abstract_method_smoke_test
Details
Linux firebase_android_embedding_v2_smoke_test
Details
Linux firebase_release_smoke_test
Details
Linux fuchsia_precache
Details
Linux tool_tests
Details
Linux web_integration_tests
Details
Linux web_long_running_tests
Details
Linux web_tests
Details
Mac build_gallery
Details
Mac build_tests
Details
Mac customer_testing
Details
Mac tool_tests
Details
WIP Ready for review
Details
Windows build_tests
Details
Windows customer_testing
Details
Windows tool_tests
Details
analyze-linux Task Summary
Details
cla/google All necessary CLAs are signed
customer_testing-linux Task Summary
Details
docs-linux Task Summary
Details
flutter-gold All golden file tests have passed.
Details
tool_tests-commands-linux Task Summary
Details
tool_tests-general-linux Task Summary
Details
web_integration_tests Task Summary
Details
@jonahwilliams jonahwilliams deleted the jonahwilliams:canvaskit_hot_restart_test branch Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.
X Tutup