Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix solution restore in libraries #38294
Merged
Conversation
|
Tagging subscribers to this area: @safern, @ViktorHofer |
|
Thanks for reporting @Anipik |
|
Interesting didn’t know this file existed. |
|
I see, thanks. Would it make sense to import |
|
Probably not as the reason why msbuild introduced the Directory.Solution.* extension point was because importing Directory.Solution.* would have been a breaking change. No need for a solution to get the full msbuild context. |
|
Makes sense. Just wondering what we needed to import and share on both kind of environments. |
ViktorHofer
merged commit 69fca92
into
master
100 checks passed
100 checks passed
dotnet-linker-tests (Build Linux x64 release Runtime_Release)
Build Linux x64 release Runtime_Release succeeded
Details
dotnet-linker-tests (Build OSX x64 release Runtime_Release)
Build OSX x64 release Runtime_Release succeeded
Details
dotnet-linker-tests (Build Windows_NT x64 release Runtime_Release)
Build Windows_NT x64 release Runtime_Release succeeded
Details
dotnet-runtime-perf (CoreCLR Product Build Linux x64 release)
CoreCLR Product Build Linux x64 release succeeded
Details
dotnet-runtime-perf (CoreCLR Product Build Windows_NT x64 release)
CoreCLR Product Build Windows_NT x64 release succeeded
Details
dotnet-runtime-perf (CoreCLR Product Build Windows_NT x86 release)
CoreCLR Product Build Windows_NT x86 release succeeded
Details
dotnet-runtime-perf (Libraries Build Linux x64 Release)
Libraries Build Linux x64 Release succeeded
Details
dotnet-runtime-perf (Libraries Build Windows_NT x64 Release)
Libraries Build Windows_NT x64 Release succeeded
Details
dotnet-runtime-perf (Libraries Build Windows_NT x86 Release)
Libraries Build Windows_NT x86 Release succeeded
Details
dotnet-runtime-perf (Mono Product Build Linux x64 release)
Mono Product Build Linux x64 release succeeded
Details
dotnet-runtime-perf (Performance Linux x64 release coreclr JIT net5.0)
Performance Linux x64 release coreclr JIT net5.0 succeeded
Details
dotnet-runtime-perf (Performance Linux x64 release mono JIT net5.0)
Performance Linux x64 release mono JIT net5.0 succeeded
Details
dotnet-runtime-perf (Performance Windows_NT x64 release coreclr JIT net5.0)
Performance Windows_NT x64 release coreclr JIT net5.0 succeeded
Details
dotnet-runtime-perf (Performance Windows_NT x86 release coreclr JIT net5.0)
Performance Windows_NT x86 release coreclr JIT net5.0 succeeded
Details
license/cla
All CLA requirements met.
runtime (Build Android arm Release AllSubsets_Mono)
Build Android arm Release AllSubsets_Mono succeeded
Details
runtime (Build Android arm64 Debug AllSubsets_Mono)
Build Android arm64 Debug AllSubsets_Mono succeeded
Details
runtime (Build Android x64 Release AllSubsets_Mono)
Build Android x64 Release AllSubsets_Mono succeeded
Details
runtime (Build Android x86 Debug AllSubsets_Mono)
Build Android x86 Debug AllSubsets_Mono succeeded
Details
runtime (Build Browser wasm Debug AllSubsets_Mono)
Build Browser wasm Debug AllSubsets_Mono succeeded
Details
runtime (Build Linux arm Debug AllSubsets_Mono)
Build Linux arm Debug AllSubsets_Mono succeeded
Details
runtime (Build Linux x64 Debug AllSubsets_Mono_LLVMJIT)
Build Linux x64 Debug AllSubsets_Mono_LLVMJIT succeeded
Details
runtime (Build Linux x64 Release AllSubsets_Mono_LLVMAOT)
Build Linux x64 Release AllSubsets_Mono_LLVMAOT succeeded
Details
runtime (Build Linux_musl x64 Release AllSubsets_Mono)
Build Linux_musl x64 Release AllSubsets_Mono succeeded
Details
runtime (Build OSX x64 Debug AllSubsets_Mono_LLVMAOT)
Build OSX x64 Debug AllSubsets_Mono_LLVMAOT succeeded
Details
runtime (Build OSX x64 Release AllSubsets_Mono_LLVMJIT)
Build OSX x64 Release AllSubsets_Mono_LLVMJIT succeeded
Details
runtime (Build iOS arm Release AllSubsets_Mono)
Build iOS arm Release AllSubsets_Mono succeeded
Details
runtime (Build iOS arm64 Debug AllSubsets_Mono)
Build iOS arm64 Debug AllSubsets_Mono succeeded
Details
runtime (Build iOS x64 Release AllSubsets_Mono)
Build iOS x64 Release AllSubsets_Mono succeeded
Details
runtime (Build tvOS arm64 Release AllSubsets_Mono)
Build tvOS arm64 Release AllSubsets_Mono succeeded
Details
runtime (Build tvOS x64 Debug AllSubsets_Mono)
Build tvOS x64 Debug AllSubsets_Mono succeeded
Details
runtime (CoreCLR Pri0 Runtime Tests Run Linux arm checked)
CoreCLR Pri0 Runtime Tests Run Linux arm checked succeeded
Details
runtime (CoreCLR Pri0 Runtime Tests Run Linux arm64 checked)
CoreCLR Pri0 Runtime Tests Run Linux arm64 checked succeeded
Details
runtime (CoreCLR Pri0 Runtime Tests Run Linux x64 checked)
CoreCLR Pri0 Runtime Tests Run Linux x64 checked succeeded
Details
runtime (CoreCLR Pri0 Runtime Tests Run OSX x64 checked)
CoreCLR Pri0 Runtime Tests Run OSX x64 checked succeeded
Details
runtime (CoreCLR Pri0 Runtime Tests Run Windows_NT arm checked)
CoreCLR Pri0 Runtime Tests Run Windows_NT arm checked succeeded
Details
runtime (CoreCLR Pri0 Runtime Tests Run Windows_NT arm64 checked)
CoreCLR Pri0 Runtime Tests Run Windows_NT arm64 checked succeeded
Details
runtime (CoreCLR Pri0 Runtime Tests Run Windows_NT x64 checked)
CoreCLR Pri0 Runtime Tests Run Windows_NT x64 checked succeeded
Details
runtime (CoreCLR Pri0 Runtime Tests Run Windows_NT x86 checked)
CoreCLR Pri0 Runtime Tests Run Windows_NT x86 checked succeeded
Details
runtime (CoreCLR Product Build FreeBSD x64 release)
CoreCLR Product Build FreeBSD x64 release succeeded
Details
runtime (CoreCLR Product Build Linux arm checked)
CoreCLR Product Build Linux arm checked succeeded
Details
runtime (CoreCLR Product Build Linux arm release)
CoreCLR Product Build Linux arm release succeeded
Details
runtime (CoreCLR Product Build Linux arm64 checked)
CoreCLR Product Build Linux arm64 checked succeeded
Details
runtime (CoreCLR Product Build Linux arm64 release)
CoreCLR Product Build Linux arm64 release succeeded
Details
runtime (CoreCLR Product Build Linux x64 checked)
CoreCLR Product Build Linux x64 checked succeeded
Details
runtime (CoreCLR Product Build Linux x64 release)
CoreCLR Product Build Linux x64 release succeeded
Details
runtime (CoreCLR Product Build Linux_musl arm64 checked)
CoreCLR Product Build Linux_musl arm64 checked succeeded
Details
runtime (CoreCLR Product Build Linux_musl arm64 release)
CoreCLR Product Build Linux_musl arm64 release succeeded
Details
runtime (CoreCLR Product Build Linux_musl x64 checked)
CoreCLR Product Build Linux_musl x64 checked succeeded
Details
runtime (CoreCLR Product Build Linux_musl x64 release)
CoreCLR Product Build Linux_musl x64 release succeeded
Details
runtime (CoreCLR Product Build OSX x64 checked)
CoreCLR Product Build OSX x64 checked succeeded
Details
runtime (CoreCLR Product Build OSX x64 release)
CoreCLR Product Build OSX x64 release succeeded
Details
runtime (CoreCLR Product Build Windows_NT arm checked)
CoreCLR Product Build Windows_NT arm checked succeeded
Details
runtime (CoreCLR Product Build Windows_NT arm release)
CoreCLR Product Build Windows_NT arm release succeeded
Details
runtime (CoreCLR Product Build Windows_NT arm64 checked)
CoreCLR Product Build Windows_NT arm64 checked succeeded
Details
runtime (CoreCLR Product Build Windows_NT arm64 release)
CoreCLR Product Build Windows_NT arm64 release succeeded
Details
runtime (CoreCLR Product Build Windows_NT x64 checked)
CoreCLR Product Build Windows_NT x64 checked succeeded
Details
runtime (CoreCLR Product Build Windows_NT x64 release)
CoreCLR Product Build Windows_NT x64 release succeeded
Details
runtime (CoreCLR Product Build Windows_NT x86 checked)
CoreCLR Product Build Windows_NT x86 checked succeeded
Details
runtime (CoreCLR Product Build Windows_NT x86 release)
CoreCLR Product Build Windows_NT x86 release succeeded
Details
runtime (CoreCLR Common Pri0 Test Build AnyOS AnyCPU checked)
CoreCLR Common Pri0 Test Build AnyOS AnyCPU checked succeeded
Details
runtime (CoreCLR GCC Product Build Linux x64 checked)
CoreCLR GCC Product Build Linux x64 checked succeeded
Details
runtime (Installer Build and Test coreclr FreeBSD_x64 Release)
Installer Build and Test coreclr FreeBSD_x64 Release succeeded
Details
runtime (Installer Build and Test coreclr Linux_arm Debug)
Installer Build and Test coreclr Linux_arm Debug succeeded
Details
runtime (Installer Build and Test coreclr Linux_arm64 Release)
Installer Build and Test coreclr Linux_arm64 Release succeeded
Details
runtime (Installer Build and Test coreclr Linux_musl_arm64 Debug)
Installer Build and Test coreclr Linux_musl_arm64 Debug succeeded
Details
runtime (Installer Build and Test coreclr Linux_musl_x64 Release)
Installer Build and Test coreclr Linux_musl_x64 Release succeeded
Details
runtime (Installer Build and Test coreclr Linux_x64 Release)
Installer Build and Test coreclr Linux_x64 Release succeeded
Details
runtime (Installer Build and Test coreclr OSX_x64 Release)
Installer Build and Test coreclr OSX_x64 Release succeeded
Details
runtime (Installer Build and Test coreclr Windows_NT_arm Debug)
Installer Build and Test coreclr Windows_NT_arm Debug succeeded
Details
runtime (Installer Build and Test coreclr Windows_NT_arm64 Debug)
Installer Build and Test coreclr Windows_NT_arm64 Debug succeeded
Details
runtime (Installer Build and Test coreclr Windows_NT_x64 Release)
Installer Build and Test coreclr Windows_NT_x64 Release succeeded
Details
runtime (Installer Build and Test coreclr Windows_NT_x86 Debug)
Installer Build and Test coreclr Windows_NT_x86 Debug succeeded
Details
runtime (Libraries Build Linux_musl arm64 Release)
Libraries Build Linux_musl arm64 Release succeeded
Details
runtime (Libraries Build Linux_musl x64 Debug)
Libraries Build Linux_musl x64 Debug succeeded
Details
runtime (Libraries Build Windows_NT allConfigurations x64 Debug)
Libraries Build Windows_NT allConfigurations x64 Debug succeeded
Details
runtime (Libraries Build Windows_NT arm Release)
Libraries Build Windows_NT arm Release succeeded
Details
runtime (Libraries Build Windows_NT arm64 Release)
Libraries Build Windows_NT arm64 Release succeeded
Details
runtime (Libraries Build Windows_NT net472 x86 Release)
Libraries Build Windows_NT net472 x86 Release succeeded
Details
runtime (Libraries Build Windows_NT x64 Debug)
Libraries Build Windows_NT x64 Debug succeeded
Details
runtime (Libraries Build Windows_NT x86 Debug)
Libraries Build Windows_NT x86 Debug succeeded
Details
runtime (Libraries Build Windows_NT x86 Release)
Libraries Build Windows_NT x86 Release succeeded
Details
runtime (Libraries Test Build Linux x64 Debug)
Libraries Test Build Linux x64 Debug succeeded
Details
runtime (Libraries Test Build Windows_NT x64 Debug)
Libraries Test Build Windows_NT x64 Debug succeeded
Details
runtime (Libraries Test Run checked coreclr Linux arm Release)
Libraries Test Run checked coreclr Linux arm Release succeeded
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Fixes #37358
VS doesn't honor the
RestoreUseStaticGraphEvaluationset in a Directory.Build.props import as that file isn't imported in a solution. Specifying the property in aDirectory.Solution.propsfile which is imported in a solution uses static graph restore and fixes the restore issue.