X Tutup
The Wayback Machine - https://web.archive.org/web/20201030183428/https://github.com/microsoft/vscode-java-debug/pull/891
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a user setting to set default vmArgs #891

Merged
merged 2 commits into from Oct 12, 2020

Conversation

@testforstephen
Copy link
Contributor

@testforstephen testforstephen commented Oct 10, 2020

Close #220
Close #876

@testforstephen testforstephen added this to the 0.29.0 milestone Oct 10, 2020
@testforstephen testforstephen force-pushed the testforstephen:jinbo_vmArgs branch from b6956d5 to ceaedf7 Oct 10, 2020
@testforstephen testforstephen requested review from Eskibear and jdneo Oct 12, 2020
@@ -730,6 +730,11 @@
"description": "%java.debugger.configuration.jdwp.requestTimeout.description%",
"default": 3000,
"minimum": 100
},
"java.debug.settings.vmArgs": {

This comment has been minimized.

@jdneo

jdneo Oct 12, 2020
Member

Do you think if it is necessary to set it as machine scope?

This comment has been minimized.

@testforstephen

testforstephen Oct 12, 2020
Author Contributor

Seems not, because vmArgs is not auto executed by the debugger. It's like vmArgs in launch.json, need user to click debug to consume it.

This comment has been minimized.

@jdneo

jdneo Oct 12, 2020
Member

I see, that's reasonable.

@jdneo
jdneo approved these changes Oct 12, 2020
@testforstephen testforstephen merged commit 2b93e81 into microsoft:master Oct 12, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
Details
@testforstephen testforstephen deleted the testforstephen:jinbo_vmArgs branch Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.
X Tutup