Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Images always rebuild due to use of DEVSPACE_RANDOM in image tag #1188
Comments
|
@khaled thanks for reporting this issue! This is actually a tricky problem since variable resolution happens very early in the command and I'll have to think about it for a good solution. As a workaround you could use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What happened?
I've noticed that my images always rebuild when running
devspace dev, despite havingpreferSyncOverRebuildset to true.It appears that using
DEVSPACE_RANDOMas part of my image tag leads to this.I'm using kaniko to build, so there's a significant unnecessary wait time every time I run
devspace dev, even though kaniko is caching the layers. In other words, a kaniko pod has to spin up, the context files are synced to the pod, layer hashes are calculated and checked against the cache for each step, etc.What did you expect to happen instead?
The image does not rebuild every time. Instead, the prior image tag is re-used, and a sync happens on startup.
How can we reproduce the bug? (as minimally and precisely as possible)
Use
DEVSPACE_RANDOMas the tag in an image.Local Environment:
Kubernetes Cluster:
Anything else we need to know?
This appears to have to do with the calculation of
imageConfigHashinhelper.go. The image config contains the tag, which is a new random value every time you rundevspace dev. Ideally there could be a special case in howimageConfigHashis calculated when DEVSPACE_RANDOM is used as part of the tag. For example, the hash could be calculated prior to replacing the DEVSPACE_RANDOM variable with a random value.A snippet from the related Slack thread:
/kind bug