Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix validation of the fields: If no fields are given, default should be to validate all fields #1979
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Hi, I had the problem, that the fields, which are marked as "required" were neither validated by creation of item nor by the update, if for example the text input was cleared again (Version: 8.8.1)
After some debugging, I've found out, that the fields which were empty on ui (e.g. on create screen) were not send to the backend. The backend on the other hand didn't consider than these fields to be validated, because there was no list of constraints to be checked for these fields (
$columnsToValidatein thevalidatePayloadmethod)I could fix the errors, as I replaced the default value of this variable to be all fields of the collection. From my point of view during the validation all constraints (Requirement is implemented as one of the constraints as I understand) should be considered, if no fields are provided (which is the case for all calls from ItemService for example)
Please note: since I'm was not able to find open issues regarding the validation as whole, I'm something wondering, that such essential functionality didn't work for me. So I would like to ask the core team to check this before merge in the master branch.
Thank you and best regards