X Tutup
The Wayback Machine - https://web.archive.org/web/20201204153409/https://github.com/sequelize/sequelize/pull/12471
Skip to content

/ sequelize

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: convert errors to typescript #12471

Merged
merged 1 commit into from Jul 7, 2020
Merged

refactor: convert errors to typescript #12471

merged 1 commit into from Jul 7, 2020

Conversation

@sushantdhiman
Copy link
Contributor

@sushantdhiman sushantdhiman commented Jul 7, 2020

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

Converted errors to typescript, fixed related tests
@sushantdhiman
refactor: convert errors to typescript
Loading status checks…
0744580
@codecov
Copy link

@codecov codecov bot commented Jul 7, 2020 •
edited

Codecov Report

Merging #12471 into master will decrease coverage by 0.09%.
The diff coverage is 99.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12471      +/-   ##
==========================================
- Coverage   96.47%   96.37%   -0.10%     
==========================================
  Files          95       95              
  Lines        9220     9254      +34     
  Branches       17       61      +44     
==========================================
+ Hits         8895     8919      +24     
  Misses        322      322              
- Partials        3       13      +10
Impacted Files Coverage Δ
src/model-manager.js 100.00% <ø> (ø)
src/errors/validation-error.ts 96.22% <95.00%> (ø)
src/dialects/mssql/async-queue.ts 100.00% <100.00%> (ø)
src/errors/aggregate-error.ts 90.00% <100.00%> (ø)
src/errors/association-error.ts 100.00% <100.00%> (ø)
src/errors/base-error.ts 100.00% <100.00%> (ø)
src/errors/bulk-record-error.ts 100.00% <100.00%> (ø)
src/errors/connection-error.ts 100.00% <100.00%> (ø)
src/errors/connection/access-denied-error.ts 100.00% <100.00%> (ø)
...ors/connection/connection-acquire-timeout-error.ts 100.00% <100.00%> (ø)
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72bc739...0744580. Read the comment docs.
@sushantdhiman sushantdhiman merged commit e053514 into master Jul 7, 2020
3 of 4 checks passed
3 of 4 checks passed
codecov/project 96.37% (+-0.10%) compared to 72bc739
Details
codecov/patch 99.28% of diff hit (target 96.47%)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sushantdhiman sushantdhiman deleted the errors-conversion branch Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
@sushantdhiman
You can’t perform that action at this time.
X Tutup