X Tutup
The Wayback Machine - https://web.archive.org/web/20201027174714/https://github.com/github/VisualStudio/pull/2493
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update publishing-an-existing-project-to-github.md #2493

Closed

Conversation

@BulldogCTISolutions
Copy link

@BulldogCTISolutions BulldogCTISolutions commented Apr 7, 2020

Hindsight is asking me to include a step before starting to clean out and remove unwanted sub-directories.

Hindsight is asking me to include a step before starting to clean out and remove unwanted sub-directories.
@@ -1,5 +1,6 @@
# Publishing an existing project to GitHub

0. Clean solution directories, bin, obj, etc. or else these will be uploaded to Github

This comment has been minimized.

@Kryptos-FR

Kryptos-FR Jul 11, 2020

That should be covered with a proper .gitignore. I think it would be better to mention that instead of a step that just states WHAT but doesn't explain WHY, nor HOW.

So maybe a note or warning "make sure to have properly set your .gitignore before adding the project" with a link to GitHub's page about .gitignore (i.e. https://docs.github.com/en/github/using-git/ignoring-files).

@jcansdale jcansdale closed this Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.
X Tutup