X Tutup
The Wayback Machine - https://web.archive.org/web/20210105192305/https://github.com/nodejs/node/issues/35793
Skip to content

/ node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Dark Mode for NodeJS docs #35793

Open
AjayPoshak opened this issue Oct 25, 2020 · 12 comments · May be fixed by #36313
Open

Enable Dark Mode for NodeJS docs #35793

AjayPoshak opened this issue Oct 25, 2020 · 12 comments · May be fixed by #36313
Labels
doc feature request help wanted

Comments

@AjayPoshak
Copy link

@AjayPoshak AjayPoshak commented Oct 25, 2020

Is your feature request related to a problem? Please describe.
Please enable dark mode for node docs like the nodejs.dev website.
@AjayPoshak
Copy link
Author

@AjayPoshak AjayPoshak commented Oct 26, 2020

I would like to work on it, if that's possible.
@DerekNonGeneric
Copy link
Member

@DerekNonGeneric DerekNonGeneric commented Oct 26, 2020

@AjayPoshak, that is possible.
@dougmellon
Copy link

@dougmellon dougmellon commented Oct 26, 2020 •
edited

@AjayPoshak If you would like help, let me know and I will lend a hand.

Also, I suggest a good first issue tag for this issue.
@dougmellon
Copy link

@dougmellon dougmellon commented Oct 29, 2020

@AjayPoshak if you are not going to take this, I'll jump on it. Just let me know.
@DerekNonGeneric
Copy link
Member

@DerekNonGeneric DerekNonGeneric commented Oct 29, 2020

@dougmellon, if you two would be interested in collaborating, that would be cool. @AjayPoshak hasn't expressed interest yet, so it's still up for grabs. May the best solution land. :)
@dougmellon
Copy link

@dougmellon dougmellon commented Oct 29, 2020

Sounds good!
@AjayPoshak
Copy link
Author

@AjayPoshak AjayPoshak commented Oct 29, 2020

@DerekNonGeneric @dougmellon I will be working on it this weekend.
@dougmellon
Copy link

@dougmellon dougmellon commented Oct 29, 2020

@DerekNonGeneric @dougmellon I will be working on it this weekend.

Awesome. Do you mind if I help out?
@AjayPoshak
Copy link
Author

@AjayPoshak AjayPoshak commented Oct 29, 2020

@dougmellon not at all. Let's work on it together.
@DerekNonGeneric
Copy link
Member

@DerekNonGeneric DerekNonGeneric commented Oct 30, 2020

Just wanted to mention to the person who makes the PR with the commit: you can add the “Co-authored-by” trailer to the end of the commit message with the other person's name and preferred email to preserve attribution.

Refs: https://github.blog/2018-01-29-commit-together-with-co-authors/#how-it-works
@AjayPoshak
Copy link
Author

@AjayPoshak AjayPoshak commented Nov 2, 2020

@dougmellon Please dm me on twitter, I could not find your contact info on profile.
jabyrd3 added a commit to jabyrd3/node that referenced this issue Nov 28, 2020
@jabyrd3
doc: add dark mode styles
04b1cb1 
Pulled colors from nodejs.dev

Refs: nodejs#35793
@jabyrd3 jabyrd3 mentioned this issue Nov 28, 2020
Open
2 of 2 tasks complete
@jabyrd3
Copy link

@jabyrd3 jabyrd3 commented Nov 28, 2020

Looks like: https://www.dropbox.com/s/78kbivu5u8ds0tb/api_docs_darkmode.png?dl=0
@AjayPoshak AjayPoshak linked a pull request that will close this issue Nov 29, 2020
Open
2 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc feature request help wanted
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Add dark mode
5 participants
@ChALkeR @jabyrd3 @AjayPoshak @DerekNonGeneric @dougmellon
You can’t perform that action at this time.
X Tutup