X Tutup
The Wayback Machine - https://web.archive.org/web/20201028100824/https://github.com/feathersjs/feathers/issues/2104
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect paginate.max even without paginate.default #2104

Open
suitupalex opened this issue Apr 23, 2020 · 0 comments
Open

Respect paginate.max even without paginate.default #2104

suitupalex opened this issue Apr 23, 2020 · 0 comments

Comments

@suitupalex
Copy link

@suitupalex suitupalex commented Apr 23, 2020

Ran into a situation today where I have to stop using paginate.default.

Long story short, I'm using feathers-mongodb and the Model.countDocuments call used by pagination isn't using my index for whatever reason and is killing my DB. I don't need the total on every query, so I removed paginate.default.

However, paginate.max is now not being respected:
https://github.com/feathersjs/databases/blob/master/packages/adapter-commons/src/filter-query.ts#L14-L23

I'm thinking that max should still be respected with or without default being set?

@daffl daffl transferred this issue from feathersjs/databases Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.
X Tutup