Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign uptest: add upstream test cases to encoding #35794
Closed
Conversation
|
Rubber-stamp LGTM |
Commit Queue failed- Loading data for nodejs/node/pull/35794 ✔ Done loading data for nodejs/node/pull/35794 ----------------------------------- PR info ------------------------------------ Title test: add upstream test cases to encoding (#35794) Author Daijiro Wachi (@watilde) Branch watilde:wpt-encoding -> nodejs:master Labels author ready, encoding, test Commits 1 - test: add upstream test cases to encoding Committers 1 - Daijiro Wachi PR-URL: https://github.com/nodejs/node/pull/35794 Refs: https://github.com/web-platform-tests/wpt/pull/25988 Refs: https://github.com/web-platform-tests/wpt/pull/26158 Reviewed-By: Rich Trott Reviewed-By: Luigi Pinca Reviewed-By: James M Snell ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/35794 Refs: https://github.com/web-platform-tests/wpt/pull/25988 Refs: https://github.com/web-platform-tests/wpt/pull/26158 Reviewed-By: Rich Trott Reviewed-By: Luigi Pinca Reviewed-By: James M Snell -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - test: add upstream test cases to encoding ✔ Last GitHub Actions successful ℹ Last Full PR CI on 2020-10-28T12:45:20Z: https://ci.nodejs.org/job/node-test-pull-request/33902/ - Querying data for job/node-test-pull-request/33902/ ✔ Build data downloaded - Querying failures of job/node-test-commit/41705/ ✔ Data downloaded ✖ 1 failure(s) on the last Jenkins CI run ℹ This PR was created on Sun, 25 Oct 2020 12:50:36 GMT ✔ Approvals: 3 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/35794#pullrequestreview-516357694 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/35794#pullrequestreview-516390612 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/35794#pullrequestreview-516925262 -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu Commit Queue action: https://github.com/nodejs/node/actions/runs/334784370 |
|
Landed in bec918f |
watilde
added a commit
that referenced
this pull request
Oct 29, 2020
Refs: web-platform-tests/wpt#25988 Refs: web-platform-tests/wpt#26158 PR-URL: #35794 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Refs: web-platform-tests/wpt#25988
Refs: web-platform-tests/wpt#26158
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes