X Tutup
The Wayback Machine - https://web.archive.org/web/20201101144558/https://github.com/nodejs/node/pull/35792
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add upstream test cases to urlsearchparams #35792

Merged
merged 1 commit into from Oct 27, 2020
Merged

Conversation

@watilde
Copy link
Member

@watilde watilde commented Oct 25, 2020

Refs: web-platform-tests/wpt#26126

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
@nodejs-github-bot

This comment has been hidden.

@watilde watilde force-pushed the watilde:wpt-url branch from b435f99 to 3bb118f Oct 25, 2020
@watilde watilde added the request-ci label Oct 25, 2020
@codecov-io

This comment has been hidden.

@github-actions github-actions bot removed the request-ci label Oct 25, 2020
@nodejs-github-bot

This comment has been hidden.

@Trott
Trott approved these changes Oct 25, 2020
Copy link
Member

@Trott Trott left a comment

Rubber-stamp LGTM

@lpinca
lpinca approved these changes Oct 25, 2020
Refs: web-platform-tests/wpt#26126

PR-URL: #35792
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott Trott force-pushed the watilde:wpt-url branch from 3bb118f to f9c9c21 Oct 27, 2020
@Trott
Copy link
Member

@Trott Trott commented Oct 27, 2020

Landed in f9c9c21

@Trott Trott merged commit f9c9c21 into nodejs:master Oct 27, 2020
19 of 20 checks passed
19 of 20 checks passed
test-asan test-asan
Details
build-tarball
Details
build-tarball
Details
build-windows-with-quic
Details
coverage-linux
Details
coverage-windows
Details
lint-addon-docs
Details
build-docs
Details
build-docs
Details
test-asan
Details
test-linux
Details
test-linux
Details
test-macOS-with-quic
Details
test-macOS-with-quic
Details
lint-cpp
Details
test-linux-with-quic
Details
lint-md
Details
lint-js
Details
lint-py
Details
lint-codeowners
Details
@watilde watilde deleted the watilde:wpt-url branch Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.
X Tutup