Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign updoc: mark ECMAScript modules implementation as stable #35781
Conversation
|
Review requested: |
guybedford
changed the title
|
As mentioned in the meeting I would like to see the commonjs named exports bake a bit longer before landing this. Thoughts? |
|
My main reason for posting this now was that it would be nice to include in the 12 backport process, since the two milestones here go together in my mind. |
|
I'm totally fine with delaying this explicit "announcement" though too. It would be good to define what we mean by settled as well. |
|
lgtm |
|
Good job @nodejs/modules-active-members !!! I know this was a long and hard journey. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Per discussion at the last meeting this is a PR to mark the entire ECMAScript modules implementation as stable while keeping the individual subfeatures unstable as appropriate.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes