X Tutup
The Wayback Machine - https://web.archive.org/web/20201025234242/https://github.com/nodejs/node/pull/35771
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fs.md (minor indentation issue in /doc) #35771

Merged
merged 1 commit into from Oct 25, 2020
Merged

Update fs.md (minor indentation issue in /doc) #35771

merged 1 commit into from Oct 25, 2020

Conversation

@ax1
Copy link
Contributor

@ax1 ax1 commented Oct 23, 2020

Indentation in https://nodejs.org/docs/latest/api/fs.html#fs_fs_promises_api is not correct (level 2 and it should be to level 3).

@Trott
Trott approved these changes Oct 23, 2020
@Trott
Copy link
Member

@Trott Trott commented Oct 23, 2020

Welcome @ax1, and thanks for the pull request!

@aduh95
aduh95 approved these changes Oct 24, 2020
@aduh95 aduh95 added the author ready label Oct 24, 2020
@lpinca
lpinca approved these changes Oct 24, 2020
@Trott
Trott approved these changes Oct 25, 2020
Indentation for #fs_fs_promises_api is level 2 but it should be level 3.

PR-URL: #35771
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@Trott Trott force-pushed the ax1:patch-1 branch from 8e73456 to bae7dde Oct 25, 2020
@Trott
Copy link
Member

@Trott Trott commented Oct 25, 2020

Landed in bae7dde

Thanks for the contribution! 🎉

@Trott Trott merged commit bae7dde into nodejs:master Oct 25, 2020
21 checks passed
21 checks passed
build-tarball
Details
build-tarball
Details
build-windows-with-quic build-windows-with-quic
Details
build-windows-with-quic build-windows-with-quic
Details
lint-addon-docs
Details
lint-addon-docs
Details
build-docs
Details
build-docs
Details
test-linux
Details
test-linux
Details
test-macOS-with-quic
Details
test-macOS-with-quic
Details
lint-cpp
Details
lint-cpp
Details
test-linux-with-quic
Details
test-linux-with-quic
Details
lint-md
Details
lint-md
Details
lint-js
Details
lint-py
Details
lint-codeowners
Details
@ax1 ax1 deleted the ax1:patch-1 branch Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
You can’t perform that action at this time.
X Tutup