X Tutup

The Wayback Machine - https://web.archive.org/web/20201023141628/https://github.com/nodejs/node/pull/35741

nodejs / node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update package.json field definitions #35741

Open

MylesBorins wants to merge 2 commits into nodejs:master from MylesBorins:update-status

+30 −26

Member

MylesBorins commented Oct 21, 2020

Only imports has the experimental status right now but technically all
ESM related features are currently experimental. The list also doesn't
appear to be in any specific order so I've grouped the experimental
features together.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines


          doc: update package.json field definitions

b77e35f

Only imports has the experimental status right now but technically all
ESM related features are currently experimental. The list also doesn't
appear to be in any specific order so I've grouped the experimental
features together.

nodejs-github-bot commented Oct 21, 2020

Review requested:

@nodejs/modules

nodejs-github-bot added the doc label

MylesBorins mentioned this pull request

stabilize packages features #35742

Open

Contributor

guybedford commented Oct 21, 2020

Thanks for looking into this. Agreed these are experimental right now.

Whether this lands should depend on whether we are able to move to considering the modules implementation in general as stable at this point, as per discussion at the meeting today.

I just checked my numbers wrt to the usage of these fields, and out of the 1.4 million packages on npm, the numbers for packages using these fields are:

"type": 7386 packages
"exports": 4815 packages
"imports": 3 packages

If we were to consider the modules implementation stable, then given the above I don't think we could also consider exports or type experimental, as this is major stable usage in the wild now.

I don't have usage numbers on exports patterns for example, but I expect it would still be low like imports.

So I feel that only these specific features of "exports" or "imports" might still fit the definition of subfeatures with experimental status if we were to move the entire implementation stable.

Member Author

MylesBorins commented Oct 21, 2020

@guybedford #35742 :P

guybedford approved these changes

DerekNonGeneric approved these changes

Member

DerekNonGeneric left a comment

👏👏👏

watilde approved these changes

ryzokuken approved these changes

Trott reviewed

doc/api/packages.md Outdated Show resolved Hide resolved

Trott reviewed

doc/api/packages.md Show resolved Hide resolved


          Update doc/api/packages.md

fe8e5b9

Co-authored-by: Rich Trott <rtrott@gmail.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can’t perform that action at this time.

X Tutup