X Tutup
The Wayback Machine - https://web.archive.org/web/20201025234650/https://github.com/nodejs/node/pull/35742
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stabilize packages features #35742

Open
wants to merge 1 commit into
base: master
from

Conversation

@MylesBorins
Copy link
Member

@MylesBorins MylesBorins commented Oct 21, 2020

These features are being used in production and are ready to be
considered stable.

Refs: nodejs/modules#564

Depends on #35741

/cc @nodejs/modules

@nodejs-github-bot
Copy link

@nodejs-github-bot nodejs-github-bot commented Oct 21, 2020

Review requested:


When a package has an [`"exports"`][] field, this will take precedence over the
`"main"` field when importing the package by name.

This comment has been minimized.

@GeoffreyBooth

GeoffreyBooth Oct 21, 2020
Member

I think @guybedford deliberately wanted this below "exports" because we want people to be preferring "exports" over "main".

This comment has been minimized.

@MylesBorins

MylesBorins Oct 21, 2020
Author Member

the ordering is changed in #35741

I can update it there

This comment has been minimized.

@guybedford

guybedford Oct 21, 2020
Contributor

I'm not tied to the ordering, it just a suggestion previously since there was no explicit ordering (it not being alphabetical).

This comment has been minimized.

@Trott

Trott Oct 22, 2020
Member

Maybe the list on L825 can have its ordering stated ("In order of precedence, the possible entries are:") while the headers can be in alphabetical order?

doc/api/packages.md Show resolved Hide resolved
@MylesBorins MylesBorins mentioned this pull request Oct 21, 2020
0 of 4 tasks complete
@codecov-io

This comment was marked as off-topic.

Copy link
Member

@mcollina mcollina left a comment

lgtm

@Trott
Copy link
Member

@Trott Trott commented Oct 22, 2020

This probably shouldn't land before the runtime deprecation in #35747 because otherwise that runtime deprecation is semver-major?

@Trott Trott added the blocked label Oct 22, 2020
doc/api/packages.md Outdated Show resolved Hide resolved
@MylesBorins
Copy link
Member Author

@MylesBorins MylesBorins commented Oct 22, 2020

@Trott the folder pathing stuff is currently no longer documented and unaffected by this change

These features are being used in production and are ready to be
considered stable.

Refs: nodejs/modules#564
@MylesBorins MylesBorins force-pushed the MylesBorins:mark-features-stable branch from fdfbd1d to c9a55e3 Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

8 participants
You can’t perform that action at this time.
X Tutup