Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upadd tests for resource JSON marshalling #55
Comments
|
Hi @willnorris I would like to take this up. I will start with |
|
This can be labeled a good-first-issue since beginners can work on writing test for different resources at the same time. |
|
Hi @jamesgeorge007! Thank you for your interest in helping out. First, you will want to read our CONTRIBUTING.md guide. Second, you will want to get familiar with the code by reading through it and trying it out. Then, I suggest following the link to the original issue where it is explained what is needed in more detail. Thanks again, and I look forward to seeing PRs from you. |
|
@jamesgeorge007 hi |
|
@palash25 As mentioned above I'm not familiar with the code-base. It would be great if you could suggest on what test case is to be written specifically. |
I have mentioned how to get familiar with the codebase. It would be great if you could re-read my previous comment, and the referenced issues and the PRs. |
|
@jamesgeorge007 Are you working on this issue? I would like to work on it |
|
@vaibhavsingh97 I think there are multiple resources that need the JSON marhsalling test so if you start with |
|
@gmlewis we can close this one |
|
I believe this is a long-running issue that is gradually being worked on by volunteers to add tests for resource JSON marshaling... so let's please keep this one open. |
|
Sure, no problems |
|
I was thinking of adding some more tests for this issue as a way to get familiar with the repo and start contributing. Would it be helpful to go down the list of public types from the godocs and start adding tests for any types that don't already have marshaling tests built? |
|
Sounds great, @ajz01 - thank you! Please make sure to read our CONTRIBUTING.md guide to help you get started. Also, this issue links a number of PRs that you can use as examples. |
|
I am planing to add some more test cases to get familiar with this repo and to get started |
|
I would assume that while the goal is to add JSON marshal tests for all types having |
…tive to key order (google#1303) Helps google#55.


see 5f1c20a for more details