X Tutup
The Wayback Machine - https://web.archive.org/web/20260322013115/https://github.com/NativeScript/NativeScript/pull/8798
Skip to content

fix(android): FlexboxLayout support for isPassThroughParentEnabled#8798

Merged
NathanWalker merged 4 commits intoNativeScript:masterfrom
CatchABus:master
Jan 29, 2021
Merged

fix(android): FlexboxLayout support for isPassThroughParentEnabled#8798
NathanWalker merged 4 commits intoNativeScript:masterfrom
CatchABus:master

Conversation

@CatchABus
Copy link
Contributor

@CatchABus CatchABus commented Aug 30, 2020 •
edited
Loading

PR Checklist

What is the current behavior?

When setting 'isPassThroughParentEnabled' property to FlexboxLayout, a exception is thrown.

What is the new behavior?

Property 'isPassThroughParentEnabled' will work for FlexboxLayout.

Fixes/Closes #8567 .

@cla-bot cla-bot bot added the cla: yes label Aug 30, 2020
@CatchABus CatchABus mentioned this pull request Aug 30, 2020
Closed
5 tasks
@CatchABus
Copy link
Contributor Author

CatchABus commented Aug 31, 2020

@NathanaelA I managed to run sample locally and correct all possible ui-tests app issues. I commited new changes, hope I didn't cause any inconvenience.

@NathanWalker
Copy link
Contributor

NathanWalker commented Sep 7, 2020

Nice work @dimitrisrk thank you. Possible to just resolve those 2 conflicts listed and then we could get this in. Everyone greatly appreciates your efforts 🤗

@CatchABus
Copy link
Contributor Author

CatchABus commented Sep 9, 2020 •
edited
Loading

Nice work @dimitrisrk thank you. Possible to just resolve those 2 conflicts listed and then we could get this in. Everyone greatly appreciates your efforts 🤗

Thank you very much, it's a pleasure having a chance to help. This PR was redone anew on NS 7 branch, so we might be talking about very small conflicts.

@CatchABus
Copy link
Contributor Author

CatchABus commented Sep 28, 2020 •
edited
Loading

I see there is trouble adapting this since paths for conflicting files have changes.
Is there anything I can do to help? Would merging all updates from main repo til now to my fork and reapplying changes help?

@CatchABus
fix: #8567 (new)
ce2d0fe 
# Conflicts:
#	apps/ui/nsconfig.json
#	apps/ui/src/flexbox/flexbox-ispassthroughparent.ts
#	apps/ui/src/flexbox/flexbox-ispassthroughparent.xml
@CatchABus
fix: Flexbox sample not running. Also, updated widgets-release.aar.
064131b 
# Conflicts:
#	apps/ui/app/flexbox/flexbox-ispassthroughparent.ts
#	apps/ui/app/flexbox/flexbox-ispassthroughparent.xml
#	apps/ui/src/flexbox/flexbox-ispassthroughparent-page.ts
#	apps/ui/src/flexbox/flexbox-ispassthroughparent-page.xml
#	apps/ui/src/flexbox/flexbox-ispassthroughparent.ts
#	apps/ui/src/flexbox/flexbox-ispassthroughparent.xml
@CatchABus
Chore: Removing 2 unused files.
b14e7f1
@CatchABus
Copy link
Contributor Author

CatchABus commented Oct 2, 2020

@NathanWalker I tried few attempts to rebase and think I got rid of these conflicts.
Hope this helps.

@CatchABus CatchABus changed the title fix: #8567 (new) fix(android): #8567 (new) Oct 19, 2020
@NathanWalker NathanWalker changed the title fix(android): #8567 (new) fix(android): FlexboxLayout support for isPassThroughParentEnabled Oct 27, 2020
@NathanWalker NathanWalker added the ready for test TSC needs to test this and confirm against live production apps and automated test suites label Nov 13, 2020
@CatchABus CatchABus marked this pull request as draft December 28, 2020 14:45
@NathanWalker NathanWalker marked this pull request as ready for review January 29, 2021 20:56
NathanWalker
NathanWalker previously approved these changes Jan 29, 2021
View reviewed changes
@NathanWalker NathanWalker merged commit 5fe2742 into NativeScript:master Jan 29, 2021
@CatchABus
Copy link
Contributor Author

CatchABus commented Jan 29, 2021 •
edited
Loading

@NathanWalker @rigor789 Thank you for examining and merging this.
One minor thing I want to point out is that FlexboxLayout class may have room for a bit of cleaning. (I had set PR to draft to investigate this)

Java class has more than 1 constructors which might be unused because TypeScript class instantiates a nativeView using constructor with a single argument. https://github.com/NativeScript/NativeScript/blob/master/packages/core/ui/layouts/flexbox-layout/index.android.ts#L91
Not sure why org.nativescript.widgets.FlexboxLayout had more than 1 constructors, but I added 1 in parent class to achieve inheritance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NathanWalker NathanWalker NathanWalker left review comments

@NathanaelA NathanaelA Awaiting requested review from NathanaelA

Assignees

@NathanaelA NathanaelA

Labels

cla: yes ready for test TSC needs to test this and confirm against live production apps and automated test suites

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

App crash with isPassThroughParentEnabled="true" set on a FlexboxLayout

4 participants

@CatchABus @NathanWalker @NathanaelA @rigor789
X Tutup