X Tutup
The Wayback Machine - https://web.archive.org/web/20221223161428/https://github.com/python/cpython/pull/22762
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-41471: Ignore invalid prefix lengths in system proxy settings on … #22762

Merged
merged 1 commit into from Oct 19, 2020
Merged

bpo-41471: Ignore invalid prefix lengths in system proxy settings on … #22762

merged 1 commit into from Oct 19, 2020

Conversation

ronaldoussoren
Copy link
Contributor

@ronaldoussoren ronaldoussoren commented Oct 19, 2020 •
edited by bedevere-bot

Ignore invalid prefix lengths (such as '172.19.0.0/40') in the system proxy settings on macOS. This matches the behaviour of Safari.

https://bugs.python.org/issue41471

@ronaldoussoren ronaldoussoren requested a review from ned-deily Oct 19, 2020
ned-deily
ned-deily approved these changes Oct 19, 2020
View changes
Copy link
Member

@ned-deily ned-deily left a comment

LGTM

@ronaldoussoren ronaldoussoren merged commit 93a1cca into python:master Oct 19, 2020
3 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Oct 19, 2020

Thanks @ronaldoussoren for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 19, 2020
@ronaldoussoren @miss-islington
bpo-41471: Ignore invalid prefix lengths in system proxy settings on …
ec2d1d7 
…macOS (pythonGH-22762)

(cherry picked from commit 93a1cca)

Co-authored-by: Ronald Oussoren <ronaldoussoren@mac.com>
@bedevere-bot
Copy link

bedevere-bot commented Oct 19, 2020

GH-22773 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 19, 2020
@ronaldoussoren @miss-islington
bpo-41471: Ignore invalid prefix lengths in system proxy settings on …
77f920e 
…macOS (pythonGH-22762)

(cherry picked from commit 93a1cca)

Co-authored-by: Ronald Oussoren <ronaldoussoren@mac.com>
@bedevere-bot
Copy link

bedevere-bot commented Oct 19, 2020

GH-22774 is a backport of this pull request to the 3.8 branch.

ronaldoussoren added a commit that referenced this pull request Oct 20, 2020
@miss-islington @ronaldoussoren
bpo-41471: Ignore invalid prefix lengths in system proxy settings on …
aa7b03b 
…macOS (GH-22762) (GH-22773)

(cherry picked from commit 93a1cca)

Co-authored-by: Ronald Oussoren <ronaldoussoren@mac.com>
ronaldoussoren added a commit that referenced this pull request Oct 20, 2020
@miss-islington @ronaldoussoren
bpo-41471: Ignore invalid prefix lengths in system proxy settings on …
e7c5a43 
…macOS (GH-22762) (GH-22774)

(cherry picked from commit 93a1cca)

Co-authored-by: Ronald Oussoren <ronaldoussoren@mac.com>
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@ronaldoussoren @adorilson
bpo-41471: Ignore invalid prefix lengths in system proxy settings on …
392d483 
…macOS (pythonGH-22762)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ned-deily ned-deily

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ronaldoussoren @miss-islington @bedevere-bot @ned-deily @the-knights-who-say-ni
X Tutup