bpo-38320: Clarify that expectedFailure is satisfied by either failur…#22740
Merged
zooba merged 1 commit intopython:masterfrom Oct 19, 2020
Merged
bpo-38320: Clarify that expectedFailure is satisfied by either failur…#22740zooba merged 1 commit intopython:masterfrom
zooba merged 1 commit intopython:masterfrom
Conversation
…e or error of the test.
Member
Author
|
Please add Skip News. |
Contributor
|
Thanks @iritkatriel for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9. |
Contributor
|
Sorry @iritkatriel and @zooba, I had trouble checking out the |
|
GH-22782 is a backport of this pull request to the 3.8 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 19, 2020
…e or error of the test. (pythonGH-22740) (cherry picked from commit fa87482) Co-authored-by: Irit Katriel <iritkatriel@yahoo.com>
Contributor
|
Thanks @iritkatriel for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9. |
|
GH-22783 is a backport of this pull request to the 3.9 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 19, 2020
…e or error of the test. (pythonGH-22740) (cherry picked from commit fa87482) Co-authored-by: Irit Katriel <iritkatriel@yahoo.com>
miss-islington
added a commit
that referenced
this pull request
Nov 18, 2020
miss-islington
added a commit
that referenced
this pull request
Nov 18, 2020
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 13, 2021
…e or error of the test. (pythonGH-22740)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…e or error of the test.
This PR clarifies that a unittest function with the expectedFailure decorator is considered to have passed if the test either fails or errors. The rest of the doc already distinguishes between failure (one of the assert* methods failed) and error (any other exception).
https://bugs.python.org/issue38320