X Tutup
The Wayback Machine - https://web.archive.org/web/20221223151540/https://github.com/python/cpython/pull/22124
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[doc] Fix broken links and improve stand-alone tools list in FAQ #22124

Merged
merged 1 commit into from Apr 26, 2021
Merged

[doc] Fix broken links and improve stand-alone tools list in FAQ #22124

merged 1 commit into from Apr 26, 2021

Conversation

andresdelfino
Copy link
Contributor

@andresdelfino andresdelfino commented Sep 6, 2020 •
edited

This fixes the obsolete URL for cx_Freeze, adds a mention to py2app, and shows the applications as a list.

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Sep 6, 2020
@andresdelfino andresdelfino changed the title Fix stand-alone binaries list [doc] Improve stand-alone tools list in FAQ Sep 6, 2020
@andresdelfino andresdelfino changed the title [doc] Improve stand-alone tools list in FAQ [doc] Fix broken links and improve stand-alone tools list in FAQ Oct 14, 2020
akuchling
akuchling reviewed Oct 19, 2020
View changes
Doc/faq/windows.rst Outdated Show resolved Hide resolved
akuchling
akuchling suggested changes Oct 19, 2020
View changes
Copy link
Member

@akuchling akuchling left a comment

I suggest updating one answer's reference to py2exe, since it now supports Python 3. Otherwise, the PR looks fine to me.

@bedevere-bot
Copy link

bedevere-bot commented Oct 19, 2020

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@andresdelfino
Copy link
Contributor Author

andresdelfino commented Oct 19, 2020

@akuchling py2exe support for Python 3 is marked as beta, with no changes since 2014. Does that count https://pypi.org/project/py2exe/

@andresdelfino
Copy link
Contributor Author

andresdelfino commented Dec 16, 2020

I have made the requested changes; please review again

@bedevere-bot
Copy link

bedevere-bot commented Dec 16, 2020

Thanks for making the requested changes!

@akuchling: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from akuchling Dec 16, 2020
@orsenthil orsenthil merged commit d28b346 into python:master Apr 26, 2021
3 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Apr 26, 2021

Thanks @andresdelfino for the PR, and @orsenthil for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 26, 2021
@andresdelfino @miss-islington
Fix broken links and improve stand-alone tools list in FAQ pythonGH-2…
52713b1 
…2124

(cherry picked from commit d28b346)

Co-authored-by: Andre Delfino <adelfino@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 26, 2021
@andresdelfino @miss-islington
Fix broken links and improve stand-alone tools list in FAQ pythonGH-2…
4a14e54 
…2124

(cherry picked from commit d28b346)

Co-authored-by: Andre Delfino <adelfino@gmail.com>
@miss-islington
Copy link
Contributor

miss-islington commented Apr 26, 2021

Thanks @andresdelfino for the PR, and @orsenthil for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Apr 26, 2021

Thanks @andresdelfino for the PR, and @orsenthil for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@orsenthil orsenthil self-assigned this Apr 26, 2021
@andresdelfino andresdelfino deleted the fix_standalone_binary branch Apr 26, 2021
kreathon pushed a commit to kreathon/cpython that referenced this pull request May 2, 2021
@andresdelfino @kreathon
Fix broken links and improve stand-alone tools list in FAQ pythonGH-2…
cd6e239 
…2124
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akuchling akuchling

Assignees

@orsenthil orsenthil

Labels
docs Documentation in the Doc dir needs backport to 3.8 needs backport to 3.9 skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@andresdelfino @bedevere-bot @miss-islington @akuchling @orsenthil @tirkarthi @the-knights-who-say-ni
X Tutup