X Tutup
The Wayback Machine - https://web.archive.org/web/20250521165910/https://github.com/angular/angular-cli/pull/19178
Skip to content

fix(@angular-devkit/build-webpack): fully close Webpack 5 compiler #19178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 22, 2020

Conversation

clydin
Copy link
Member

@clydin clydin commented Oct 22, 2020

The Webpack 5 compiler now contains a close function that should be called when the compiler is finished.

@google-cla google-cla bot added the cla: yes label Oct 22, 2020
@clydin clydin added the target: patch This PR is targeted for the next patch release label Oct 22, 2020
@clydin clydin requested a review from alan-agius4 October 22, 2020 15:56
@clydin clydin force-pushed the webpack5-compiler-close branch from 66778e1 to ed9163e Compare October 22, 2020 16:57
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Oct 22, 2020
@clydin clydin merged commit 17e9f38 into angular:master Oct 22, 2020
@clydin clydin deleted the webpack5-compiler-close branch October 22, 2020 19:17
@clydin clydin added target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release labels Oct 22, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
X Tutup