Add a statement in the string_decoder.md #35585
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
addaleax
approved these changes
Oct 10, 2020
Trott
reviewed
Oct 11, 2020
doc/api/string_decoder.md
Outdated
| @@ -71,6 +71,7 @@ substitution characters appropriate for the character encoding. | |||
|
|
|||
| If the `buffer` argument is provided, one final call to `stringDecoder.write()` | |||
| is performed before returning the remaining input. | |||
| After `end` is called, the `stringDecoder` object can be reused for new input. | |||
There was a problem hiding this comment.
Suggested change
| After `end` is called, the `stringDecoder` object can be reused for new input. | |
| After `end()` is called, the `stringDecoder` object can be reused for new input. |
There was a problem hiding this comment.
@Trott - thanks for the review, I have followed your suggestion. Please have a look.
Trott
approved these changes
Oct 11, 2020
lpinca
approved these changes
Oct 19, 2020
github-actions
bot
removed
the
request-ci
gireeshpunathil
approved these changes
Oct 20, 2020
gireeshpunathil
pushed a commit
that referenced
this issue
Oct 20, 2020
PR-URL: #35585 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
|
landed in 50103bf |
BethGriggs
pushed a commit
that referenced
this issue
Oct 21, 2020
PR-URL: #35585 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Merged
BethGriggs
pushed a commit
that referenced
this issue
Dec 8, 2020
PR-URL: #35585 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
BethGriggs
pushed a commit
that referenced
this issue
Dec 10, 2020
PR-URL: #35585 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Merged
BethGriggs
pushed a commit
that referenced
this issue
Dec 15, 2020
PR-URL: #35585 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes