lib: refactor Socket._getpeername and Socket._getsockname #32969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
reviewed
Apr 27, 2020
BridgeAR
reviewed
May 23, 2020
BridgeAR
reviewed
May 24, 2020
jasnell
approved these changes
May 25, 2020
bnoordhuis
approved these changes
May 26, 2020
| if (!this._handle || !this._handle.getpeername) { | ||
| return this._peername || {}; | ||
| } else if (!this._peername) { | ||
| this._peername = {}; |
There was a problem hiding this comment.
This is a functional change in that before errors can be transient, i.e., the first call can return an empty object while the second call can return a full-fledged address object. Now errors are no longer transient because the empty object is cached.
It's a probably inconsequential change in behavior but I'd label it semver-major anyway.
Himself65
added
the
author ready
jasnell
added
the
semver-major
|
Marking semver-major per #32969 (comment) |
BridgeAR
force-pushed
the
master
branch
2 times, most recently
from
8ae28ff
to
2935f72
Compare
|
@nodejs/tsc ... since this is semver-major we need another TSC signoff |
jasnell
removed
the
author ready
|
Removed the author ready because this needs at least one more tsc signoff in order to land |
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
github-actions
bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/32969 ✔ Done loading data for nodejs/node/pull/32969 ----------------------------------- PR info ------------------------------------ Title lib: refactor Socket._getpeername and Socket._getsockname (#32969) Author Himself65 (@Himself65) Branch Himself65:20200421-address -> nodejs:master Labels author ready, net, semver-major Commits 5 - lib: refactor Socket._getpeername and Socket._getsockname - fixup! - fixup! backport - fixup! - fixup! edit comment Committers 2 - himself65 - GitHub PR-URL: https://github.com/nodejs/node/pull/32969 Refs: https://github.com/nodejs/node/blob/7893c70970adfbefb1684c48d42aff7385a2afb8/src/node_internals.h#L79-L85 Reviewed-By: James M Snell Reviewed-By: Ben Noordhuis Reviewed-By: Matteo Collina ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/32969 Refs: https://github.com/nodejs/node/blob/7893c70970adfbefb1684c48d42aff7385a2afb8/src/node_internals.h#L79-L85 Reviewed-By: James M Snell Reviewed-By: Ben Noordhuis Reviewed-By: Matteo Collina -------------------------------------------------------------------------------- ✔ Last GitHub Actions successful ℹ Last Full PR CI on 2020-10-16T23:28:31Z: https://ci.nodejs.org/job/node-test-pull-request/33684/ - Querying data for job/node-test-pull-request/33684/ ✔ Build data downloaded - Querying failures of job/node-test-commit/41438/ ✔ Data downloaded ✖ 2 failure(s) on the last Jenkins CI run ℹ This PR was created on Tue, 21 Apr 2020 12:04:10 GMT ✔ Approvals: 3 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/32969#pullrequestreview-417884204 ✔ - Ben Noordhuis (@bnoordhuis): https://github.com/nodejs/node/pull/32969#pullrequestreview-418200196 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/32969#pullrequestreview-464801397 -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu Commit Queue action: https://github.com/nodejs/node/actions/runs/311694300 |
|
Landed in 1428db8 |
aduh95
pushed a commit
that referenced
this issue
Oct 19, 2020
PR-URL: #32969 Refs: https://github.com/nodejs/node/blob/7893c70970adfbefb1684c48d42aff7385a2afb8/src/node_internals.h#L79-L85 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos
removed
the
commit-queue-failed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Refs:
node/src/node_internals.h
Lines 79 to 85 in 7893c70
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes