X Tutup
The Wayback Machine - https://web.archive.org/web/20201023141530/https://github.com/nodejs/node/pull/35746
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v14.15.0 proposal #35746

Open
wants to merge 3 commits into
base: v14.x
from
Open

v14.15.0 proposal #35746

wants to merge 3 commits into from

Conversation

@richardlau
Copy link
Member

@richardlau richardlau commented Oct 22, 2020

2020-10-27, Version 14.15.0 'Fermium' (LTS), @richardlau

Notable Changes

This release marks the transition of Node.js 14.x into Long Term Support (LTS)
with the codename 'Fermium'. The 14.x release line now moves into "Active LTS"
and will remain so until October 2021. After that time, it will move into
"Maintenance" until end of life in April 2023.

Commits

  • [90a5d59824] - doc: fix Node.js 14.x changelogs (Richard Lau) #35756
  • [7f788573b3] - Revert "test: mark test-webcrypto-encrypt-decrypt-aes flaky" (Myles Borins) #35666

@nodejs/releasers FYI this was generated via nodejs/node-core-utils#514, including the notable changes in the changelog and updating the test file.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
This reverts commit 3d21792.

PR-URL: #35666
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
richardlau added a commit that referenced this pull request Oct 22, 2020
Notable changes:

This release marks the transition of Node.js 14.x into Long Term Support (LTS)
with the codename 'Fermium'. The 14.x release line now moves into "Active LTS"
and will remain so until October 2021. After that time, it will move into
"Maintenance" until end of life in April 2023.

PR-URL: #35746
@richardlau richardlau force-pushed the v14.15.0-proposal branch from 7da6074 to eae3ce4 Oct 22, 2020
@richardlau
Copy link
Member Author

@richardlau richardlau commented Oct 22, 2020

This is the first LTS 14.x release and as such any commits should generally have been on current for two weeks as per https://github.com/nodejs/Release#lts-staging-branches. We try to keep the first LTS release light in terms of numbers of commits -- it's primarily to flip the LTS bit on and have the release declare itself as LTS. I'm proposing not having to run CITGM on this.

The first LTS release is semver-minor according to https://github.com/nodejs/node/blob/master/doc/guides/releases.md#lts-releases.

Copy link
Member

@targos targos left a comment

The table in CHANGELOG_V14 should be split in two columns. See the one in V12 for example

@@ -31,7 +31,8 @@ release.
</tr>
<tr>
<td valign="top">
<b><a href="doc/changelogs/CHANGELOG_V14.md#14.14.0">14.14.0</a></b><br/>
<b><a href="doc/changelogs/CHANGELOG_V14.md#14.15.0">14.15.0</a></b><br/>
<a href="doc/changelogs/CHANGELOG_V14.md#14.14.0">14.14.0</a><br/>

This comment has been minimized.

@targos

targos Oct 22, 2020
Member

Line 27 should be updated.

richardlau added a commit that referenced this pull request Oct 22, 2020
Notable changes:

This release marks the transition of Node.js 14.x into Long Term Support (LTS)
with the codename 'Fermium'. The 14.x release line now moves into "Active LTS"
and will remain so until October 2021. After that time, it will move into
"Maintenance" until end of life in April 2023.

PR-URL: #35746
@richardlau richardlau force-pushed the v14.15.0-proposal branch from eae3ce4 to f3d4f9f Oct 22, 2020
@richardlau richardlau mentioned this pull request Oct 22, 2020
3 of 3 tasks complete
CHANGELOG.md Outdated Show resolved Hide resolved
@richardlau
Copy link
Member Author

@richardlau richardlau commented Oct 22, 2020

The table in CHANGELOG_V14 should be split in two columns. See the one in V12 for example

Fixed this in the tooling. Found an existing issue in the changelogs for 14.x: #35746 (comment)
Will rerun the tooling and update once #35756 lands.

richardlau added 2 commits Oct 22, 2020
Remove the table headings for Node.js 13.x that were not removed in
631dd21.

Vertically align the list of releases in the 14.x changelog as they
are in the changelogs for 12.x and 10.x.

PR-URL: #35756
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Notable changes:

This release marks the transition of Node.js 14.x into Long Term Support (LTS)
with the codename 'Fermium'. The 14.x release line now moves into "Active LTS"
and will remain so until October 2021. After that time, it will move into
"Maintenance" until end of life in April 2023.

PR-URL: #35746
@richardlau richardlau force-pushed the v14.15.0-proposal branch from f3d4f9f to ce2b234 Oct 22, 2020
@richardlau
Copy link
Member Author

@richardlau richardlau commented Oct 22, 2020

The changelog changes should be good now. @targos PTAL.

@targos
targos approved these changes Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.
X Tutup