Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign uptls: allow reading data into a static buffer #35753
Conversation
|
Review requested: |
3397b90
to
12c6ad0
12c6ad0
to
15dcd4b
|
lgtm |
This comment has been hidden.
This comment has been hidden.
|
It looks like codecov is living its own life. I'm failing to understand how the changes from this PR may decrease code coverage by |
|
Marked codecov message as hidden. See #35759 (comment) for more details. |


Refs: #25436
Adds
onreadoption support intotls.connect(). The option is only used when thesocketis not specified. The end behavior is the same as withnet.connect()'sonreadoption. Just like with thenet's option, it's a client side feature.Also, adds new
benchmark/tls/throughput-s2c.jsbenchmark to test the option and renames the existingthroughput.jsbenchmark intothroughput-c2s.jsto have consistent naming.Refs: #25436
Benchmark results (here
recvbuflen=0stands for the current behavior of allocating a new buffer for each chunk read):Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes