X Tutup
The Wayback Machine - https://web.archive.org/web/20210309004154/https://github.com/webpack/webpack-dev-server/pull/2007
Skip to content

/ webpack-dev-server

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: don't use --runInBand and improve execution performance #2007

Merged
merged 1 commit into from Jun 10, 2019
Merged

test: don't use --runInBand and improve execution performance #2007

merged 1 commit into from Jun 10, 2019

Conversation

@hiroppy
Copy link
Member

@hiroppy hiroppy commented Jun 10, 2019

backport from #2005 to master branch

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

modify only

Motivation / Use-Case

see #2005

Breaking Changes

no

Additional Info
@hiroppy hiroppy requested a review from alexander-akait as a code owner Jun 10, 2019
@hiroppy hiroppy changed the title test: don't use --runInBand and improve execution performance test: don't use --runInBand and improve execution performance(backport from next) Jun 10, 2019
@codecov
Copy link

@codecov codecov bot commented Jun 10, 2019 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (master@2b4cb52). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2007   +/-   ##
=========================================
  Coverage          ?   92.77%           
=========================================
  Files             ?       29           
  Lines             ?     1149           
  Branches          ?      327           
=========================================
  Hits              ?     1066           
  Misses            ?       79           
  Partials          ?        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b4cb52...bfbf543. Read the comment docs.
@alexander-akait
alexander-akait reviewed Jun 10, 2019
View changes
Copy link
Member

@alexander-akait alexander-akait left a comment

Good work! Feel free to merge when CI will be greean
@hiroppy
Copy link
Member Author

@hiroppy hiroppy commented Jun 10, 2019

I'll change the setup code because Node6 doesn't support Object.entries.
@hiroppy hiroppy force-pushed the feature/modify-jest-backport branch from d76d7cc to 8be7932 Jun 10, 2019
@hiroppy
Copy link
Member Author

@hiroppy hiroppy commented Jun 10, 2019

@evilebottnawi PTAL
@alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented Jun 10, 2019

Something wrong with CI and need resolve conflict
@hiroppy
test: don't use --runInBand and improve execution performance
Verified
This commit was signed with a verified signature.
hiroppy Yuta Hiroto
GPG key ID: E03998F3E2B165C2 Learn about signing commits
Loading status checks…
bfbf543 
backport from #2005 to master branch
@hiroppy hiroppy force-pushed the feature/modify-jest-backport branch from 8be7932 to bfbf543 Jun 10, 2019
@hiroppy
Copy link
Member Author

@hiroppy hiroppy commented Jun 10, 2019

Resolved
@hiroppy hiroppy mentioned this pull request Jun 10, 2019
Merged
1 of 6 tasks complete
@alexander-akait
alexander-akait approved these changes Jun 10, 2019
View changes
@hiroppy hiroppy changed the title test: don't use --runInBand and improve execution performance(backport from next) test: don't use --runInBand and improve execution performance Jun 10, 2019
@hiroppy hiroppy merged commit 4dec6b2 into master Jun 10, 2019
15 checks passed
15 checks passed
licence/cla Contributor License Agreement is signed.
Details
webpack.webpack-dev-server Build #20190610.12 had test failures
Details
webpack.webpack-dev-server (Lint) Lint succeeded
Details
webpack.webpack-dev-server (Linux node-10) Linux node-10 succeeded
Details
webpack.webpack-dev-server (Linux node-12) Linux node-12 succeeded
Details
webpack.webpack-dev-server (Linux node-6) Linux node-6 succeeded
Details
webpack.webpack-dev-server (Linux node-8) Linux node-8 succeeded
Details
webpack.webpack-dev-server (Windows node-10) Windows node-10 succeeded
Details
webpack.webpack-dev-server (Windows node-12) Windows node-12 succeeded
Details
webpack.webpack-dev-server (Windows node-6) Windows node-6 succeeded
Details
webpack.webpack-dev-server (Windows node-8) Windows node-8 succeeded
Details
webpack.webpack-dev-server (macOS node-10) macOS node-10 succeeded
Details
webpack.webpack-dev-server (macOS node-12) macOS node-12 succeeded
Details
webpack.webpack-dev-server (macOS node-6) macOS node-6 succeeded
Details
webpack.webpack-dev-server (macOS node-8) macOS node-8 succeeded
Details
@hiroppy hiroppy deleted the feature/modify-jest-backport branch Jun 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-akait alexander-akait

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@hiroppy @alexander-akait
X Tutup