X Tutup
The Wayback Machine - https://web.archive.org/web/20210120013024/https://github.com/mkdocs/mkdocs/pull/2109
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to GitHub Actions from Travis #2109

Closed
wants to merge 9 commits into from
Closed

Conversation

@waylan
Copy link
Member

@waylan waylan commented May 12, 2020

This is a work in progress.

Still need to add a deploy workflow and remove the Travis config.

Addresses #2032.

waylan added 2 commits May 12, 2020
This is a work in progress. Still need to add a deploy workflow and
remove the Travis config.
@waylan
Copy link
Member Author

@waylan waylan commented May 12, 2020

@tomchristie I believe you need to enable "Actions" for the entire org. Go to the mkdocs organization page, select the "Settings" tab (which is not available to me), select "Actions" from the sidebar, ensure the "Enable local & third party Actions for this organization" option is checked and click "Save". Note that in another project of mine, the "Enable local & third party Actions for this organization" was already selected, but things didn't work until after I "saved" it. Once you do that once, it should be good going forward.

Please report back here afterward so I can push another change to trigger a run. Thanks.

@tomchristie
Copy link
Contributor

@tomchristie tomchristie commented May 12, 2020

Done. 👍
Also, we should make you an org admin too.

@tomchristie
Copy link
Contributor

@tomchristie tomchristie commented May 12, 2020

Switched you to owner on the org too, not sure why we’d not done that before really.

waylan added 3 commits May 12, 2020
@waylan
Copy link
Member Author

@waylan waylan commented May 12, 2020

Something is still preventing the actions from running. Not sure what. I don't see any errors in the config file. If anyone else whats to take a look, fell free.

@facelessuser
Copy link
Contributor

@facelessuser facelessuser commented May 18, 2020

If you were to create a branch directly on the repo does it work?

@epicfaace
Copy link

@epicfaace epicfaace commented Jul 4, 2020

@waylan Try removing the "tags" section?

Try replacing the top condition with something like

on:
  push:
    branches: [ master ]
  pull_request:
    branches: [ master ]
@facelessuser
Copy link
Contributor

@facelessuser facelessuser commented Jul 4, 2020

@epicfaace it's not that because I have it set up the same way with no issues: https://github.com/facelessuser/soupsieve/blob/master/.github/workflows/build.yml.

This was referenced Jul 5, 2020
@facelessuser
Copy link
Contributor

@facelessuser facelessuser commented Jul 5, 2020

@epicfaace, I see you've uploaded a test. You'll see that it doesn't work either. I'm pretty certain that if a branch was created directly on the mkdocs repo, not a fork, that it would work. I think once it is running and committed to master, forks could work. That is assuming that actions are correctly enabled on the mkdocs repo, but I do not have permission to check such things 🤷.

@waylan
Copy link
Member Author

@waylan waylan commented Jul 6, 2020

I'm pretty certain that if a branch was created directly on the mkdocs repo, not a fork, that it would work.

Based on my testing, this is not a factor. It works either way assuming there are no other issues.

@facelessuser
Copy link
Contributor

@facelessuser facelessuser commented Jul 6, 2020

You're probably right. When the actions work, they work pretty good, but when they don't it can be cryptic why it fails. That is probably my one complaint.

On a lesser note, sometimes certain combinations you'd expect to work one way, and it seems to not work that way at all. It can be surprising at times.

@waylan
Copy link
Member Author

@waylan waylan commented Nov 4, 2020

I'm pretty certain that if a branch was created directly on the mkdocs repo, not a fork, that it would work.

I decided to test this and created a PR on my own fork. Sure enough, the checks began to run immediately. Still having a weird issue with PYPY3 and Windows though. Once I get that worked out, I'll move it to here. Any help with the issue would be appreciated as it has me stumped.

@facelessuser
Copy link
Contributor

@facelessuser facelessuser commented Nov 4, 2020

I decided to test this and created a PR on my own fork. Sure enough, the checks began to run immediately.

It is nice to have that theory confirmed.

Any help with the issue would be appreciated as it has me stumped.

I'll see if I can squirrel away some time and see if anything stands out to me.

@waylan
Copy link
Member Author

@waylan waylan commented Nov 5, 2020

Turns out the problem with pypy is a known bug, which has been fixed and should be available in the next release of pypy. See tox-dev/tox#1704 for details. In the meantime, I disabled running the Windows/pypy combination of tests. With that, everything it working now at waylan#4.

@waylan
Copy link
Member Author

@waylan waylan commented Nov 5, 2020

I'm closing this in favor of #2223, which is on a branch of the mkdocs project within the org rather than from an external fork. Of course, the checks ran upon creating the PR.

@waylan waylan closed this Nov 5, 2020
@waylan waylan deleted the waylan:workflow branch Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.
X Tutup