X Tutup
The Wayback Machine - https://web.archive.org/web/20201020032457/https://github.com/python/python-docs-theme/issues/13
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make theme safe for parallel reading? #13

Closed
pitrou opened this issue Mar 28, 2018 · 7 comments
Closed

Make theme safe for parallel reading? #13

pitrou opened this issue Mar 28, 2018 · 7 comments

Comments

@pitrou
Copy link
Member

@pitrou pitrou commented Mar 28, 2018

When trying to run sphinx-build with -j16, I get the following warning:

WARNING: the python_docs_theme extension does not declare if it is safe for parallel reading, assuming it isn't - please ask the extension author to check and make it explicit
WARNING: doing serial read
@theacodes
Copy link
Collaborator

@theacodes theacodes commented Mar 28, 2018

If you want to test it out and see if it's fine with parallel read, I'm happy to merge a PR to add this.

@pitrou
Copy link
Member Author

@pitrou pitrou commented Mar 28, 2018

What is required to declare it safe? Not a Sphinx theme expert :-)

@theacodes
Copy link
Collaborator

@theacodes theacodes commented Mar 28, 2018

@pitrou
Copy link
Member Author

@pitrou pitrou commented Mar 28, 2018

Ok, I tested it on the CPython docs and it worked fine.

@theacodes
Copy link
Collaborator

@theacodes theacodes commented Mar 28, 2018

Cool, want to send a PR?

@pitrou
Copy link
Member Author

@pitrou pitrou commented Mar 28, 2018

Hmm, I've just deleted my python-docs-theme clone... AFAIR it's just a matter of returning the required dict from setup() in __init__.py.

@theacodes
Copy link
Collaborator

@theacodes theacodes commented Mar 28, 2018

No worries, I'll make it happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.
X Tutup