Restify can't sendRaw none `utf8` data - it always encoded to utf-8 #1852

denhub · 2020-07-24T16:25:37Z

Hello!

Thanks for Restify - it's absolutely cool!

I found a bug in the function sendRaw - when you try to send none utf8 data in response - you can't do it. Data always will be encoded to utf-8.

I use charSet - to set latin1 encoding for sending ansi mp3-file.

res.charSet('latin1').sendRaw(200, mp3fileData,{
	'Content-Type': 'audio/mpeg',
});

But it's take affect only for Content-Type field.

Cause

In response.js does not send second param encoding to http write method. Http Docs.

node-restify/lib/response.js

Line 874 in 9153587

res.write(res._data);

Are you willing and able to fix this?

Yes I can.

    // Send body if it was provided
    if (res._data) {
        // https://nodejs.org/api/http.html#http_response_write_chunk_encoding_callback
        // Default: 'utf8'
        let encoding = 'utf8';

        // Check :: is encoding valid?
        // in my point of view - we must validate encoding - in charSet() method
        // https://nodejs.org/docs/latest-v12.x/api/buffer.html#buffer_buffers_and_character_encodings
        let characterEncodingsSupportedByNodeJs = [
            'utf8',
            'utf16le',
            'latin1',
            'base64',
            'hex',
            'ascii',
            'binary',
            'ucs2',
        ];
        let characterEncodingsSupportedByNodeJs_id = characterEncodingsSupportedByNodeJs.indexOf(res._charSet);
        if ( characterEncodingsSupportedByNodeJs_id > -1 ) encoding = characterEncodingsSupportedByNodeJs[characterEncodingsSupportedByNodeJs_id];

        res.write(res._data, encoding);
    }

``

The text was updated successfully, but these errors were encountered:

Dec	JAN	Feb
	16
2020	2021	2022

restify / node-restify

Restify can't sendRaw none `utf8` data - it always encoded to utf-8 #1852

Restify can't sendRaw none `utf8` data - it always encoded to utf-8 #1852

denhub commented Jul 24, 2020 •

edited

restify / node-restify

Restify can't sendRaw none `utf8` data - it always encoded to utf-8 #1852

Restify can't sendRaw none `utf8` data - it always encoded to utf-8 #1852

Comments

denhub commented Jul 24, 2020 • edited

Cause

Are you willing and able to fix this?

denhub commented Jul 24, 2020 •

edited