X Tutup
The Wayback Machine - https://web.archive.org/web/20201019100815/https://github.com/TheAlgorithms/Python/pull/3469
Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Patience Sort #3469

Merged
merged 9 commits into from Oct 18, 2020
Merged

Add Patience Sort #3469

merged 9 commits into from Oct 18, 2020
+65 −0

Conversation

@JoaoVictorNascimento
Copy link
Contributor

@JoaoVictorNascimento JoaoVictorNascimento commented Oct 18, 2020 •
edited

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@JimmyRaper
Add Patience Sort
Loading status checks…
0cd6ba4
@TravisBuddy
Copy link

@TravisBuddy TravisBuddy commented Oct 18, 2020

Travis tests have failed

Hey @JoaoVictorNascimento,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 682f2050-10eb-11eb-af89-615b230ba186
JimmyRaper added 7 commits Oct 18, 2020
@JimmyRaper
fix code for pre-commit
Loading status checks…
4728f50
@JimmyRaper
Fix params def
Loading status checks…
0998ba7
@JimmyRaper
Adding new line at end of file
Loading status checks…
f5df57f
@JimmyRaper
Remove Trailing Whitespace
Loading status checks…
819bdac
@JimmyRaper
Adding space between the methods of the Stack class
Loading status checks…
47378c9
@JimmyRaper
Removing Trailing Whitespace
Loading status checks…
9ee58dc
@JimmyRaper
Ordering Imports
Loading status checks…
3e4dfe4
@JoaoVictorNascimento
Copy link
Contributor Author

@JoaoVictorNascimento JoaoVictorNascimento commented Oct 18, 2020

@mateuszz0000 could you review my pull request?
@mateuszz0000
mateuszz0000 requested changes Oct 18, 2020
View changes
sorts/patience_sort.py
from functools import total_ordering
from heapq import merge

"""

This comment has been minimized.

Sign in to view
@mateuszz0000

mateuszz0000 Oct 18, 2020
Member

Please provide some url for theory

This comment has been minimized.

Sign in to view
@JoaoVictorNascimento

JoaoVictorNascimento Oct 18, 2020
Author Contributor

Added
@JimmyRaper
Adding url patience sort
Loading status checks…
8d41a4d
@mateuszz0000
mateuszz0000 approved these changes Oct 18, 2020
View changes
Copy link
Member

@mateuszz0000 mateuszz0000 left a comment

Nice! Well done :)
@mateuszz0000 mateuszz0000 merged commit 79d5755 into TheAlgorithms:master Oct 18, 2020
3 checks passed
3 checks passed
codespell
Details
pre-commit
Details
Travis CI - Pull Request Build Passed
Details
@JoaoVictorNascimento
Copy link
Contributor Author

@JoaoVictorNascimento JoaoVictorNascimento commented Oct 18, 2020

Thanks @mateuszz0000! Could you put the hacktoberfest-accepted label?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateuszz0000 mateuszz0000

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@JoaoVictorNascimento @TravisBuddy @mateuszz0000 @JimmyRaper
You can’t perform that action at this time.
X Tutup