X Tutup
The Wayback Machine - https://web.archive.org/web/20201106204351/https://github.com/TheAlgorithms/C-Sharp/pull/131
Skip to content

/ C-Sharp

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable nullable context in all projects #131

Merged
merged 9 commits into from Jan 18, 2020
Merged

Enable nullable context in all projects #131

merged 9 commits into from Jan 18, 2020

Conversation

@siriak
Copy link
Member

@siriak siriak commented Dec 26, 2019 •
edited

Enabled nullable context, updated targets for that, fixed emerged issues

  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have added comments to hard-to-understand areas of my code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have made corresponding changes to the comments
  • I have made corresponding changes to the README.md
siriak added 5 commits Dec 26, 2019
@siriak
Enable nullable context in all projects
Loading status checks…
6a1a20b
@siriak
Merge branch 'master' into enable-nullable
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
6f85302
@siriak
Merge branch 'master' into enable-nullable
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a966708
@siriak
Update to .net 3.0
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
01a6412
@siriak
Update to .net 3.1
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b264e17
@codecov
Copy link

@codecov codecov bot commented Jan 17, 2020 •
edited

Codecov Report

Merging #131 into master will decrease coverage by 0.53%.
The diff coverage is 83.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #131      +/-   ##
==========================================
- Coverage   87.35%   86.82%   -0.54%     
==========================================
  Files          51       53       +2     
  Lines        1946     2125     +179     
==========================================
+ Hits         1700     1845     +145     
- Misses        246      280      +34
Impacted Files Coverage Δ
Algorithms/Strings/NaiveStringSearch.cs 100% <100%> (ø) ⬆️
...tructures/DoublyLinkedList/DoublyLinkedListNode.cs 100% <100%> (ø)
...ataStructures/DoublyLinkedList/DoublyLinkedList.cs 81.39% <81.39%> (ø)
Algorithms/Search/FastSearcher.cs 95.65% <0%> (-4.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e00751...e1fa08b. Read the comment docs.
siriak added 4 commits Jan 18, 2020
@siriak
Remove BitArray comparison behavior
Loading status checks…
0e00751
@siriak
Merge branch 'master' into enable-nullable
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
abcee81
@siriak
Fix build issues
Loading status checks…
6f21f65
@siriak
Add comments to exceptions
Loading status checks…
e1fa08b
@siriak
Copy link
Member Author

@siriak siriak commented Jan 18, 2020

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 4
           

Complexity increasing per file
==============================
- DataStructures/SinglyLinkedList/SinglyLinkedList.cs  3
- DataStructures/DoublyLinkedList/DoublyLinkedList.cs  2

See the complete overview on Codacy
@siriak siriak merged commit 5db3e7a into master Jan 18, 2020
4 of 6 checks passed
4 of 6 checks passed
codecov/patch 83.83% of diff hit (target 87.35%)
Details
codecov/project 86.82% (-0.54%) compared to 0e00751
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
guardrails/scan no new security issues detected (in 26,322,975m48s)
Details
@siriak siriak deleted the enable-nullable branch Jan 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
@siriak
You can’t perform that action at this time.
X Tutup