X Tutup
The Wayback Machine - https://web.archive.org/web/20201019030143/https://github.com/SnapKit/SnapKit/pull/529
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ACL and ConstraintAttributes #529

Open
wants to merge 2 commits into
base: develop
from

Conversation

@cruisediary
Copy link

@cruisediary cruisediary commented Aug 11, 2018

  • Remove internal access control level bacause it is default access control level in Swift 4

Default Access Levels
All entities in your code (with a few specific exceptions, as described later in this chapter) have a default access level of internal if you don’t specify an explicit access level yourself. As a result, in many cases you don’t need to specify an explicit access level in your code.

https://docs.swift.org/swift-book/LanguageGuide/AccessControl.html

  • Refactor ConstraintAttributes using enum's Dot syntax
// as is
return ConstraintItem(target: self.target, attributes: ConstraintAttributes.centerX)
// to be
return ConstraintItem(target: self.target, attributes: .centerX)
cruisediary added 2 commits Aug 11, 2018
because internal access control level is default in Swift4
@cruisediary
Copy link
Author

@cruisediary cruisediary commented Oct 19, 2018

@robertjpayne Please, Any update ? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.
X Tutup