X Tutup
The Wayback Machine - https://web.archive.org/web/20201211085421/https://github.com/TheAlgorithms/Go/pull/187
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up code a bit #187

Closed
wants to merge 6 commits into from
Closed

Clean up code a bit #187

wants to merge 6 commits into from

Conversation

@reverse
Copy link

@reverse reverse commented Oct 2, 2020

-Tried to fix the main re-declaration issues
-Rename some directories for better clarity #149
Tried to fix go-lint throwing err on whitespace in the dir name #149

@reverse
Copy link
Author

@reverse reverse commented Oct 2, 2020

This is a really inadequate fix, but it fixes the issues people are having with constant build fails.

@reverse reverse requested review from cclauss and vedantmamgain as code owners Oct 17, 2020
@@ -29,6 +29,6 @@ jobs:
- run: golangci-lint run --no-config other || true
- run: golangci-lint run --no-config searches || true
- run: golangci-lint run --no-config sorts
- run: golangci-lint run --no-config strings
- run: golangci-lint run --no-config "strings/multiple string matching" || true
- run: golangci-lint run --no-config strings || true

This comment has been minimized.

@cclauss

cclauss Oct 17, 2020
Member

I object to this change. We need more tests to be mandatory, not fewer.

@reverse reverse closed this Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.
X Tutup