X Tutup
The Wayback Machine - https://web.archive.org/web/20260302202852/https://github.com/github/docs/pull/618
Skip to content

Update storing-workflow-data-as-artifacts.md#618

Merged
lucascosti merged 2 commits intogithub:mainfrom
untitaker:patch-1
Oct 20, 2020
Merged

Update storing-workflow-data-as-artifacts.md#618
lucascosti merged 2 commits intogithub:mainfrom
untitaker:patch-1

Conversation

@untitaker
Copy link
Contributor

@untitaker untitaker commented Oct 17, 2020

Why:

No subcommand called builds, I know this is trying to refer to a subcommand but it's just confusing when skimming.

I did not open an issue beforehand because this change is trivial, so if rejected there's no sunken cost.

What's being changed:

Remove code tags around builds as builds is not literally referring to an identifier builds but rather build. It's just confusing.

Check off the following:

  • All of the tests are passing. -- NO. no idea which tests to run for this, but I assume this will not break anything
  • I have reviewed my changes in staging -- NO. what's staging?
  • For content changes, I have reviewed the localization checklist
  • For content changes, I have reviewed the Content style guide for GitHub Docs. -- Yeah I think there's nothing in there that speaks against this change

@untitaker
Update storing-workflow-data-as-artifacts.md
de69c71 
No subcommand called `builds`, I know this is trying to refer to a subcommand but it's just confusing when skimming.
@welcome
Copy link

welcome bot commented Oct 17, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@janiceilene
Copy link
Contributor

janiceilene commented Oct 19, 2020

👋 @untitaker Thanks for opening a PR! It is a small change and your explanation in the PR template worked instead of an issue.

All of the tests are passing. -- NO. no idea which tests to run for this, but I assume this will not break anything

The tests run automatically in the checks for every PR and it looks like all of yours are passing 💚

I have reviewed my changes in staging -- NO. what's staging?

We don't explain that anywhere, do we? I should update that in the PR template. The staging is visible by clicking the "View deployment" button, then navigating to the page you made changes to. Your changes are visible here.

image

I'll get this triaged for review!

@janiceilene janiceilene added actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team labels Oct 19, 2020
@lucascosti lucascosti self-assigned this Oct 20, 2020
lucascosti
lucascosti approved these changes Oct 20, 2020
View reviewed changes
Copy link
Contributor

@lucascosti lucascosti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks, @untitaker, I'll get this merged.

@lucascosti lucascosti merged commit ceb9733 into github:main Oct 20, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Oct 20, 2020

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@lucascosti lucascosti lucascosti approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@lucascosti lucascosti

Labels

actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@untitaker @janiceilene @lucascosti
X Tutup