X Tutup
The Wayback Machine - https://web.archive.org/web/20241215182318/https://github.com/python/cpython/pull/22656
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.9] bpo-41739: Fix test_logging.test_race_between_set_target_and_flush() (GH-22655) #22656

Merged
merged 1 commit into from
Oct 12, 2020
Merged

[3.9] bpo-41739: Fix test_logging.test_race_between_set_target_and_flush() (GH-22655) #22656

merged 1 commit into from
Oct 12, 2020

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Oct 11, 2020

The test now waits until all threads complete to avoid leaking
running threads.

Also, use regular threads rather than daemon threads.

(cherry picked from commit 13ff396)

https://bugs.python.org/issue41739

…H-22655)

The test now waits until all threads complete to avoid leaking
running threads.

Also, use regular threads rather than daemon threads.

(cherry picked from commit 13ff396)
@vsajip vsajip merged commit f5393dc into python:3.9 Oct 12, 2020
@miss-islington
Copy link
Contributor

Thanks @vstinner for the PR, and @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 12, 2020
…ythonGH-22655) (pythonGH-22656)

The test now waits until all threads complete to avoid leaking
running threads.

Also, use regular threads rather than daemon threads.

(cherry picked from commit 13ff396)
(cherry picked from commit f5393dc)

Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-bot
Copy link

GH-22662 is a backport of this pull request to the 3.8 branch.

vstinner added a commit that referenced this pull request Oct 12, 2020
…H-22655) (GH-22656) (GH-22662)

The test now waits until all threads complete to avoid leaking
running threads.

Also, use regular threads rather than daemon threads.

(cherry picked from commit 13ff396)
(cherry picked from commit f5393dc)

Co-authored-by: Victor Stinner <vstinner@python.org>

Co-authored-by: Victor Stinner <vstinner@python.org>
@vstinner vstinner deleted the test_logging39 branch January 19, 2021 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
X Tutup