Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upOS umask Context Manager #8020
OS umask Context Manager #8020
Conversation
|
Thank you for your PR! This pattern occurs in certbot_apache/http_01.py as well as certbot/compat/filesystem.py if you'd like to use this there as well! |
|
Python 2 seems to be acting up when I try to import
|
|
To fix the Travis failures, you need to update this line to Whats going on here is the tests are trying to run Documenting how all this works is tracked by #7647. |
|
I'm not entirely sure what you have in mind when you say it might affect things beyond this PR, but yes, I think the changes I described should be made in this PR. This PR is making our Apache plugin require the latest version of Certbot which I think is the best approach, but tests will fail until the Apache plugin's dependencies are updated to state this. |

Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.

This PR addresses #7992, creating a context manager in
certbot.utiland implementing its use in the places theos.umask/finallypattern is used in the current codebase.Pull Request Checklist
mastersection ofcertbot/CHANGELOG.mdto include a description of the change being made.AUTHORS.mdif you like.