X Tutup
The Wayback Machine - https://web.archive.org/web/20201225023142/https://github.com/sendgrid/sendgrid-php/issues/606
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the number of tests for each existing unit test #606

Open
thinkingserious opened this issue May 19, 2018 · 1 comment
Open

Increase the number of tests for each existing unit test #606

thinkingserious opened this issue May 19, 2018 · 1 comment

Comments

@2mt-heuser
Copy link
Contributor

@2mt-heuser 2mt-heuser commented Oct 24, 2018

Did some first work on this but also have a question / point for discussion:
Some of the Testcases in there look more like an integration, behaviour or 'set of features'-test to me.

Wouldn't this folder, being for unittests, normally include like ClassnameTest.php for all the classes inside /lib/ and test only the methods of a single file at a time / mock out external stuff.

Just like the MailHelperTest which I looked through?

So to get the coverage and quality desired it should be more like adding simple but plentiful tests for every single class and not just extend the current ones, or am I missing something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.
X Tutup