X Tutup
The Wayback Machine - https://web.archive.org/web/20201202054803/https://github.com/NeTEx-CEN/NeTEx/pull/36
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature dutypart vehicleref #36

Open
wants to merge 2 commits into
base: master
from

Conversation

@skinkie
Copy link
Contributor

@skinkie skinkie commented Jan 4, 2019

This is a WIP. But I would really would like to see some feedback :-)

skinkie added 2 commits Jan 3, 2019
@Aurige
Copy link
Contributor

@Aurige Aurige commented Jan 4, 2019

Hello Stefan
I agree that these typos should be fixed, but this is also changing some tag names, and therefore may generate some incompatibilities with previous versions. So if we decide to do this, we need to have a very clear list of such changes to be validated with the group, and also anticipate some possible solutions (like substitution group) for those already using these tags.

@skinkie
Copy link
Contributor Author

@skinkie skinkie commented Jan 4, 2019

@Aurige this is the pull you want to comment on.
#35

@Aurige
Copy link
Contributor

@Aurige Aurige commented Jan 4, 2019

Yes, that's this issue, fixing AccountingTIme to AccountingTime, is something we should probably do, also it changes the tag name... with possible compatibility issue

@skinkie
Copy link
Contributor Author

@skinkie skinkie commented Jan 4, 2019

You are commenting on #36 not #35.

@skinkie skinkie self-assigned this Jan 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.
X Tutup