X Tutup
The Wayback Machine - https://web.archive.org/web/20210210104040/https://github.com/github/gitignore/pull/3550
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .textClipping to exclusions #3550

Open
wants to merge 1 commit into
base: master
from
Open

Conversation

@nmdange2
Copy link

@nmdange2 nmdange2 commented Oct 13, 2020

I ran into the issue referenced in #3523 and I'm not sure how to fix it. I want to add the .textClipping exclusion without breaking the other rule so this pull request should not be accepted until the other one is first.

Reasons for making this change:

Files with the .textClipping extension should be ignored.

Links to documentation supporting these rule changes:

Per https://en.wikipedia.org/wiki/TextClipping this file is created when text is dragged and dropped to a folder. The file created can't be shared between computers.

Per https://en.wikipedia.org/wiki/TextClipping this file is created when text is dragged and dropped to a folder.  The file created can't be shared between computers.
@i-to-r
Copy link

@i-to-r i-to-r commented Oct 22, 2020

Did you edit the macOS.gitignore file through a browser (https://github.com/github/gitignore/edit/master/Global/macOS.gitignore)?

And if so, did you see the message:

We’ve detected the file has mixed line endings. When you commit changes we will normalize them to Windows-style (CRLF).

?

@53jk1
53jk1 approved these changes Oct 23, 2020
@i-to-r
Copy link

@i-to-r i-to-r commented Oct 24, 2020

@nmdange2, unfortunately the fix #3523 won't help you directly. GitHub online editor (browser, CodeMirror editor) still corrupts the Icon[␍] rule (i-to-r/gitignore@123480c), but the fix will preserve the line endings of the rest of rules (i.e. the message "We’ve detected the file has mixed line endings. […]" will not appear).

After the fix #3523 is ​​merged, you should make a commit using, for example, GitHub Desktop and the default TextEdit.app to edit the file (among web browser based editors: latest Atom works fine too, but old Brackets 1.8 don't — but in GitHub Desktop, you can still select which changed lines to include in the commit partial commit ).

@nmdange2
Copy link
Author

@nmdange2 nmdange2 commented Oct 25, 2020

@i-to-r Thanks I'll try redoing the commit in something other than a web browser

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
X Tutup