Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Update Node.gitignore #3549
Open
Update Node.gitignore #3549
+1
−0
Conversation
Propose adding .vscode to gitignore=> I can see how passing along your vscode workspace setting could be nice to someone working on the same project. However, because 1. .vscode is often automatically generated by vscode application 2. .vscode is application specific file 3. .vscode is meant (i speak from a linux standpoint) is meant to be hidden .vscode should be on the template default .gitignore.
|
Personal IDE settings would be in the user settings, no? I feel like the workspace settings are meant to enforce code styles and what not. |
|
Yes, but by tying settings into a specific editing application are you not forcing anyone who works on the codebase to use vscode? Is that an appropriate precedent to set, especially considering git version-control is used very often in open source codebase? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Reason:
Personal IDE settings do not belong in code base.
documentation of ".vscode" file:
https://code.visualstudio.com/docs/getstarted/settings
If this is a new template: