X Tutup
The Wayback Machine - https://web.archive.org/web/20201014002637/https://github.com/docker/docker-py/pull/2646
Skip to content

/ docker-py

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update default API version to 1.39 in docs #2646

Open
wants to merge 1 commit into
base: master
from
Open

Update default API version to 1.39 in docs #2646

wants to merge 1 commit into from

Conversation

@wxh06
Copy link

@wxh06 wxh06 commented Aug 18, 2020

@thaJeztah #2512 b4beaaa

BTW, Travis CI's pre-installed Docker server version 18.06.0-ce does not support API v1.39 but 1.38.
So I suggest changing the default to 1.38 or auto.

Build system information
docker version
Client:
 Version:           18.06.0-ce
 API version:       1.38
 Go version:        go1.10.3
 Git commit:        0ffa825
 Built:             Wed Jul 18 19:11:02 2018
 OS/Arch:           linux/amd64
 Experimental:      false
Server:
 Engine:
  Version:          18.06.0-ce
  API version:      1.38 (minimum version 1.12)
  Go version:       go1.10.3
  Git commit:       0ffa825
  Built:            Wed Jul 18 19:09:05 2018
  OS/Arch:          linux/amd64
  Experimental:     false
@wxh06
Update default API version to 1.39 in docs
Verified
This commit was signed with a verified signature.
wxh06 汪心禾 Wang, Xinhe
GPG key ID: 0792B3266B499A3B Learn about signing commits
Loading status checks…
aff023b 
#2512

Signed-off-by: 汪心禾 <wangxinhe06@gmail.com>
@wxh06 wxh06 force-pushed the wxh06:master branch from 3bb6894 to aff023b Aug 18, 2020
@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Aug 18, 2020

Looks like this is a duplicate of #2640 ?

BTW, Travis CI's pre-installed Docker server version 18.06.0-ce does not support API v1.39 but 1.38.

Do they have a public issue tracker? Docker 18.06.0 reached EOL two years ago, and has known vulnerabilities; they really, really shouldn't be using that version anymore
@wxh06
Copy link
Author

@wxh06 wxh06 commented Aug 19, 2020

@thaJeztah
Do they have a public issue tracker?

Travis CI - Help Center § Get help from our support engineers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@wxh06 @thaJeztah
You can’t perform that action at this time.
X Tutup