X Tutup
The Wayback Machine - https://web.archive.org/web/20201020112430/https://github.com/go-sql-driver/mysql/pull/697
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Docker Compose for testing #697

Open
wants to merge 1 commit into
base: master
from

Conversation

@AlekSi
Copy link
Contributor

@AlekSi AlekSi commented Oct 29, 2017

Description

See #695 and https://travis-ci.org/AlekSi/mysql.

When this is merged, https://github.com/go-sql-driver/mysql/wiki/Testing needs to be updated.

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary
  • Added myself / the copyright holder to the AUTHORS file
@julienschmidt
Copy link
Member

@julienschmidt julienschmidt commented Nov 12, 2017

#696 was merged and there is now a conflict in .travis.yml. Please rebase on current master

@AlekSi AlekSi force-pushed the AlekSi:docker-compose branch 4 times, most recently from 3dcbab0 to 4163dc2 Jan 25, 2018
@AlekSi AlekSi changed the title WIP: Use Docker Compose for testing Use Docker Compose for testing Jan 31, 2018
@AlekSi
Copy link
Contributor Author

@AlekSi AlekSi commented Jan 31, 2018

PTAL. Two tests are failing:

  • With MySQL 8.0 due to #625, which is required by 8.0.4.
  • With MySQL 5.5 – that looks like a genuine bug. Hopefully, with this PR it will be easier for one to make a local 5.5 setup and investigate this issue.
Copy link
Member

@methane methane left a comment

I love this.
Please don't forget to update Wiki Page after merge.

@AlekSi
Copy link
Contributor Author

@AlekSi AlekSi commented Jan 31, 2018

I don't have permissions for this.

@AlekSi
Copy link
Contributor Author

@AlekSi AlekSi commented Feb 5, 2018

@julienschmidt julienschmidt added this to the v1.5 milestone Mar 3, 2018
@julienschmidt
Copy link
Member

@julienschmidt julienschmidt commented May 21, 2018

Hi @AlekSi, my plan would be to merge this shortly after the 1.4.0 release, which I hope we will have ready tomorrow.

The wiki write access is currently restricted since many edits weren't exactly improving the content when everyone could edit it. Of course you could post the changes and someone with write access can apply them — or if you and/or the other Percona folks have a long-term interest in contributing to this project, I would also be open to talk about giving push access to the repository (which unfortunately can not be separated from wiki write access). A few more hands certainly wouldn't hurt.

@AlekSi AlekSi force-pushed the AlekSi:docker-compose branch from 4163dc2 to 776cdf0 May 22, 2018
@AlekSi AlekSi force-pushed the AlekSi:docker-compose branch from 776cdf0 to 737bcb9 Jun 16, 2018
@AlekSi
Copy link
Contributor Author

@AlekSi AlekSi commented Jun 16, 2018

Rebased, PTAL.

@julienschmidt
Copy link
Member

@julienschmidt julienschmidt commented Jun 18, 2018

In general it looks fine to me.
One small problem is, that you started testing with MySQL 5.5, which currently fails and probably requires some check to skip (a part of) the failing test.

prot = env("MYSQL_TEST_PROT", "tcp")
addr = env("MYSQL_TEST_ADDR", "localhost:3306")
addr = env("MYSQL_TEST_ADDR", "127.0.0.1:3307")

This comment has been minimized.

@methane

methane Oct 20, 2018
Member

Don't change default port to 3307

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.
X Tutup