Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUse Docker Compose for testing #697
Conversation
|
#696 was merged and there is now a conflict in |
3dcbab0
to
4163dc2
|
PTAL. Two tests are failing:
|
|
I don't have permissions for this. |
|
Poke @julienschmidt |
|
Hi @AlekSi, my plan would be to merge this shortly after the 1.4.0 release, which I hope we will have ready tomorrow. The wiki write access is currently restricted since many edits weren't exactly improving the content when everyone could edit it. Of course you could post the changes and someone with write access can apply them — or if you and/or the other Percona folks have a long-term interest in contributing to this project, I would also be open to talk about giving push access to the repository (which unfortunately can not be separated from wiki write access). A few more hands certainly wouldn't hurt. |
|
Rebased, PTAL. |
|
In general it looks fine to me. |
| prot = env("MYSQL_TEST_PROT", "tcp") | ||
| addr = env("MYSQL_TEST_ADDR", "localhost:3306") | ||
| addr = env("MYSQL_TEST_ADDR", "127.0.0.1:3307") |

Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.

Description
See #695 and https://travis-ci.org/AlekSi/mysql.
When this is merged, https://github.com/go-sql-driver/mysql/wiki/Testing needs to be updated.
Checklist