X Tutup
The Wayback Machine - https://web.archive.org/web/20200828080936/https://github.com/RocketChat/Rocket.Chat/pull/13541
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Discussions #13541

Merged
merged 156 commits into from Mar 8, 2019
Merged

[NEW] Discussions #13541

merged 156 commits into from Mar 8, 2019

Conversation

@ggazzo
Copy link
Member

ggazzo commented Feb 21, 2019

closes #1112
replaces and close #11803

mrsimpson and others added 30 commits Jul 20, 2018
for renaming-safe linking if necessary
@ggazzo ggazzo temporarily deployed to rocket-chat-pr-13541 Mar 7, 2019 Inactive
ggazzo added 2 commits Mar 7, 2019
@ggazzo ggazzo temporarily deployed to rocket-chat-pr-13541 Mar 7, 2019 Inactive
@sampaiodiego sampaiodiego temporarily deployed to rocket-chat-pr-13541 Mar 8, 2019 Inactive
@sampaiodiego sampaiodiego force-pushed the threads branch from 82141fa to 881980e Mar 8, 2019
@sampaiodiego sampaiodiego temporarily deployed to rocket-chat-pr-13541 Mar 8, 2019 Inactive
@sampaiodiego sampaiodiego temporarily deployed to rocket-chat-pr-13541 Mar 8, 2019 Inactive
@sampaiodiego sampaiodiego changed the title [WIP][ONLY TO BUILD] - Threads [NEW] Threads Mar 8, 2019
sampaiodiego added 3 commits Mar 8, 2019
@sampaiodiego sampaiodiego merged commit b93b31b into develop Mar 8, 2019
4 of 5 checks passed
4 of 5 checks passed
ci/circleci: build-and-test/hold Your job is on hold on CircleCI!
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: test-with-oplog-mongo-3-2 Your tests passed on CircleCI!
Details
ci/circleci: test-with-oplog-mongo-4-0 Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details
This was referenced Mar 8, 2019
@reetp reetp mentioned this pull request Mar 13, 2019
mushroomgenie added a commit to mushroomgenie/Rocket.Chat that referenced this pull request Mar 19, 2019
Co-authored-by: Oliver Jägle <github@beimir.net>
Co-authored-by: vickyokrm <vickyokrm@gmail.com>
@engelgabriel engelgabriel changed the title [NEW] Threads [NEW] Discussions Mar 21, 2019
@engelgabriel
Copy link
Member

engelgabriel commented Mar 21, 2019

We have decided that was better to delay our v1 release and get the Threads done properly than get the feature out the way it was initially implemented on the develop branch. We have "rebranded" our current implementation of Threads to Discussions (was it creates a new room type) and will implement Threads exactly the same way as Slack does.

In our vision there are 2 different use cases on how to break out of the main conversation: one very easy and organic, with a single click for small side talk, and other, much more structured, that creates a new conversation with its own life cycle.

We have tried to have a single solution for both, and as a result, no one was happy with it.
So we have given up on having a single approach for both use cases and will implement both: the Slack-like industry standard and our brand new one, called Discussions.

#13843

@engelgabriel engelgabriel mentioned this pull request Apr 5, 2019
@engelgabriel engelgabriel deleted the threads branch Apr 7, 2019
@rodrigok rodrigok mentioned this pull request Apr 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

6 participants
You can’t perform that action at this time.
X Tutup